Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add player's mother club details #1401

Closed
wsbrenk opened this issue Mar 12, 2022 · 8 comments
Closed

[FEATURE] Add player's mother club details #1401

wsbrenk opened this issue Mar 12, 2022 · 8 comments
Assignees
Milestone

Comments

@wsbrenk
Copy link
Collaborator

wsbrenk commented Mar 12, 2022

Added in playerdetails Version 2.9
-MotherClub
Container for the mother club of the player.
Added in this Version
TeamID : unsigned Integer
The globally unique TeamID of the mother club of the player.
Added in this Version
TeamName : String
The full team name of the mother club of the player.

@wsbrenk wsbrenk self-assigned this Mar 12, 2022
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 12, 2022

this file is only used for nt players in HO. chpp file players does not include this details.

@wsbrenk wsbrenk removed their assignment Mar 12, 2022
@sophiastr
Copy link
Contributor

Hello, i want to deal with this issue.
Do you still need help?
I am beginner, is that a problem?
I will work really hard.

@akasolace
Copy link
Collaborator

@sophiastr help always welcome. Maybe worth to have more inputs .... @wsbrenk what do you have in mind with this one ? Where do you want to add this info ? Also, I am not sure I understand your last comment

this file is only used for nt players in HO. chpp file players does not include this details.

@sophiastr
Copy link
Contributor

I am willing to try and work hard. More specifically, I'm looking for a project to work on intensively in the coming months. I have worked a lot in Java but not in such a popular project.
If I find an issue, can you assign it to me?
Thanks

@akasolace
Copy link
Collaborator

sure, I am ok to assign this one to you but you need to know more precisely what is required ....
Let's wait for extra info from @wsbrenk

@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Mar 27, 2022

@akasolace , @sophiastr i found, that until now, this chpp-file (playerdetails) is not used for normal players in HO. Only NT players get infos from that file.
For me changing this was to expensive for getting only such limited additional information.

the idea of the use case was to show the player's mother club name in player overview table in an extra colum.

@sophiastr
Copy link
Contributor

Thanks for your reply. I will look for it too and I will ask you if I need something. I will deal with this issue later because i am working on another issue.

@wsbrenk wsbrenk added this to the 7.0 milestone Apr 29, 2022
@wsbrenk wsbrenk self-assigned this Jul 10, 2022
@wsbrenk
Copy link
Collaborator Author

wsbrenk commented Jul 11, 2022

new columns:

	new ColumnDescriptor("MotherclubId", Types.INTEGER, true),
	new ColumnDescriptor("MotherclubName", Types.VARCHAR, true, 255),
	new ColumnDescriptor("MatchesCurrentTeam", Types.INTEGER, true)

wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Jul 12, 2022
@wsbrenk wsbrenk mentioned this issue Jul 12, 2022
2 tasks
wsbrenk added a commit that referenced this issue Jul 12, 2022
* typos in docs

* #1576 logger infos about the used database

* #1401 new columns mother club and matches current team

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk wsbrenk closed this as completed Jul 12, 2022
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 18, 2022
* typos in docs

* ho-dev#1576 logger infos about the used database

* ho-dev#1401 new columns mother club and matches current team

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants