Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Training estimation #1661

Closed
masterpatje opened this issue Oct 14, 2022 · 9 comments
Closed

[FEATURE] Training estimation #1661

masterpatje opened this issue Oct 14, 2022 · 9 comments
Assignees
Labels
status: needs test might be fixed, needs test before closing
Milestone

Comments

@masterpatje
Copy link

In general for long term it would be interesting to again look at the training estimation. My experience is that the skill gain in training is a bit quicker then the estimations in HO at the moment. With a 76% training efficiency (based on hattrick calculations) I have the idea that my training speed is quite faster then calculations in HO. If I remember correctly training speed in hattrick has increased since already quite some seasons (>5 seasons). Training is an important aspect in hattrick so maybe for long term re-check the calculations? How can I help with practical findings?

I know there is a module preferences -> training to tweak the training speed a bit, but I am unsure how to use (some of) it. And how important / sensitive the fields are for the calculations. Certainly for the bottom part (factors for the training %).

Ps. The title "presumably trainingweek per talent" is a bit unclear. My assumption is that talent has something to do with age, but what do you exactly mean?
I think that the title probably should be something like "Estimated Training Weeks for Skill Increase (reference 17 year talent) to be more descriptive. And maybe an explanation icon.

image

And what does the option Future weeks do?
image

Hattrick uses training efficiency: (maybe bottom part (factor for the training %) can be shown as an efficiency calculation and recalculates after adjusting. So that there is a better understanding of the effect.
image

Hopefully this is usefull to gain insight in possibilities to improve HO in long term.

@wsbrenk wsbrenk added this to the 7.0 milestone Oct 15, 2022
@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 19, 2022

@masterpatje looking on player statistic panel shows the development of the skills very good i think. The displayed skill development fits very well with the actual course. There are no jumps to be seen. The situation is somewhat different with osmosis training, where the development seems to be underestimated.
This is particularly blatant with my goalkeeper, whose development is not taken into account at all in the playmaking training.
and the skill loss of old players is also overestimated.

@wsbrenk wsbrenk self-assigned this Nov 20, 2022
wsbrenk added a commit that referenced this issue Nov 20, 2022
)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 20, 2022

info from Schum's thread concerning skill drops:

First, a little background.
10 seasons ago, namely 08.05.2017, changed the mechanics of skill drops.
In fact, DropAge and DropLevel were separated in time.

DropAge was left, as it was before, on Monday.
And DropLevel was moved to the training update, and summed up with the training.

And if before that, after training the skill to "Colossal" and above, and switching the training to a secondary skill, the main skill began to fall, then after the changes it stopped happening.

As a result, the strategy of leveling the primary skill to "Colossal", and the mandatory switch to a secondary skill, ceased to be relevant.

But in total, the speed of pumping high-level young players has not changed at all.
see https://www88.hattrick.org/Forum/Read.aspx?t=17404127&n=10&v=6

wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Nov 20, 2022
wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Nov 20, 2022
# Conflicts:
#	src/main/java/core/training/WeeklyTrainingType.java
wsbrenk added a commit that referenced this issue Nov 20, 2022
* #1661 PlaymakingWeeklyTraining fix osmosis training of goalkeeper

* #1661 skill drop calculation changed (use Schums formula)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 20, 2022

skill drop formula from Schum gives much better results.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 20, 2022

i have to check if the configuration of skill calculation still has any effect - if not i will remove it.

@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Nov 20, 2022
@masterpatje
Copy link
Author

Before I can give feedback I need probably 5-13 weeks to get an indication for players, because most player still have a build up subskill based on the old skill drop calculation.

Questions:

  • Does the changed calculation has an effect on recalculation functions?
  • Do you have an idea how I can test the working of the last implementation? (what to look for in your oppinion)
  • Is it an idea to seperate the configuration of skill calculation functionality to another ticket? Could you do so?

@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 26, 2022

  1. the new formula is used in weekly and in recalculation as well.
  2. So you can recalc and check in your statistic panel if there are suspicuous jumps in skill development.
  3. yes and yes - i will do so.

@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 27, 2022

  In the training update, a decrease in skill cannot occur.
  But depending on the skill level and age of the player, there is a decrease in the growth of the trained skill.

this message from Schum was not taken into account. i will fix that!

@masterpatje
Copy link
Author

"skill level and age"
Might that be the reason that I experienced that younger players (<25) were on a high subskill level when on lower skill levels? Because on lower skill and lower age the negative effects are less than in earlier versions of HO?

Or is this a wrong conclusion?

@wsbrenk
Copy link
Collaborator

wsbrenk commented Nov 27, 2022

@masterpatje the skill drop depended on skill level and age all the time. the amount slightly changed with the new formula i found on Schum's thread.

the mistake i made with the first implementation was, that i reduced subskill in any case. now i interprete the referenced message, that the dropLevel part of skill decrease only reduces the training effect - conclusion: No training No dropLevel decrease.

Beside dropLevel part, there is a dropAge part, that happens on monday independently on training settings.

wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Nov 27, 2022
wsbrenk added a commit that referenced this issue Nov 27, 2022
…hat are not trained) (#1720)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk wsbrenk closed this as completed Dec 11, 2022
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 18, 2022
…er (ho-dev#1708)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 18, 2022
…ev#1709)

* ho-dev#1661 PlaymakingWeeklyTraining fix osmosis training of goalkeeper

* ho-dev#1661 skill drop calculation changed (use Schums formula)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
wsbrenk added a commit to wsbrenk/HO that referenced this issue Dec 18, 2022
…ills that are not trained) (ho-dev#1720)

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Development

No branches or pull requests

2 participants