Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Improve first start experience #1760

Closed
tychobrailleur opened this issue Dec 18, 2022 · 4 comments
Closed

[FEATURE] Improve first start experience #1760

tychobrailleur opened this issue Dec 18, 2022 · 4 comments
Assignees
@wsbrenk
Labels
status: needs test might be fixed, needs test before closing
Milestone
7.0

Comments

@tychobrailleur
Copy link
Collaborator

tychobrailleur commented Dec 18, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
When starting HO for the first time, the experience is somewhat bad, as the application spends an awfully long time downloading past lineups and logos.

This is in particular confusing because there is a lot of work going on in the background, despite the progress bar being full.

Describe the solution you'd like
We could first download the team players, and give interactivity to the user, so they can look at their players, and in the background download the missing records. This would require some refactoring as to how data is downloaded from CHPP, which would not be a bad thing. :-)

Additional context
N/A
@wsbrenk
Copy link
Collaborator

wsbrenk commented Dec 18, 2022

Default of "Export" directory selection should be changed from c:\ (which might not be accessible) to something like %APPDATA%/HO/hrfs

@wsbrenk
Copy link
Collaborator

wsbrenk commented Dec 18, 2022

@tychobrailleur improve first download experience (the start of an empty HO happens very fast;-)

@tychobrailleur
Copy link
Collaborator Author

@tychobrailleur improve first download experience (the start of an empty HO happens very fast;-)

Correct, although when I say first start, I think of the app as a whole when using for the first time. But yes, in particular that first download! ;-)

@wsbrenk wsbrenk self-assigned this Dec 25, 2022
@wsbrenk wsbrenk added this to the 7.0 milestone Dec 25, 2022
@wsbrenk wsbrenk mentioned this issue Dec 25, 2022
Closed
2 tasks
wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Dec 25, 2022
ho-dev#1760 fix release_notes.md
7987457
@wsbrenk wsbrenk mentioned this issue Dec 25, 2022
Merged
2 tasks
@wsbrenk
Copy link
Collaborator

wsbrenk commented Dec 25, 2022

the complete transfer history of the team is downloaded when transfer panel is refreshed. this is not really part of the standard download.

removing the transfer module from auto startup list makes the first download much faster.

wsbrenk pushed a commit to wsbrenk/HO that referenced this issue Dec 28, 2022
Merge remote-tracking branch 'upstream/master' into ho-dev#1760
393e454 
# Conflicts:
#	src/main/java/core/db/DBManager.java
#	src/main/java/core/db/SquadInfoTable.java
#	src/main/java/core/db/UserColumnsTable.java
#	src/main/java/module/playerOverview/SpielerTrainingsVergleichsPanel.java
#	src/main/java/module/teamAnalyzer/ht/HattrickManager.java
#	src/main/java/module/teamAnalyzer/report/TeamReport.java
#	src/main/java/module/teamAnalyzer/ui/RecapPanelTableModel.java
#	src/main/java/module/teamAnalyzer/vo/SquadInfo.java
#	src/main/java/module/teamAnalyzer/vo/TeamLineup.java
#	src/main/java/module/transfer/test/PlayerTransferIncomePanel.java
#	src/main/java/module/transfer/test/TestDialog.java
#	src/main/java/module/transfer/test/WagesOverviewPanel.java
#	src/main/java/module/transfer/test/WagesPanel.java
#	src/main/java/module/transfer/test/WagesSumPanel.java
#	src/main/resources/sprache/English.properties
wsbrenk added a commit that referenced this issue Dec 28, 2022
@wsbrenk
#1760 (#1765)
8c89e30 
* improve XMLWorldDetailsParser.initWorldDetailsMap if next time the HT access to worlddetails file failes longer than next training week

* #1624 fix player compare when sold player is bought back again

* #1624 release_notes.md

* new match event 818- player are brothers

* new match event ids

* WorldDetailLeague.allLeagues

* #347 pre match analysis in team analyzer

* #347 refactoring team analyzer recap table

* #347 SquadInfo

* #347 SquadInfo column header

* #347 download squad info of all teams in analyzer

* #347 FixedColumnsTable

* #347 recap table reset when selection changed

* #347 team analyser settings

* #347 UserColumnsTable.loadModel does not reset isDisplay on first start

* #347 release_notes.md

* #1718 remove training formula settings

* #1288 new column HTMS-28 in player overview

* #1288 new column HTMS in player overview

* #1753 ModuleManager.firstStart remove transfer module from auto startup modules

* #1753 ModuleManager.firstStart remove transfer module from auto startup modules

* #1760 fix release_notes.md

* #1755 remove transfer test

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label Dec 28, 2022
tychobrailleur pushed a commit that referenced this issue Dec 29, 2022
@wsbrenk
#1448 player table column format (#1769)
54cee67 
* improve XMLWorldDetailsParser.initWorldDetailsMap if next time the HT access to worlddetails file failes longer than next training week

* #1624 fix player compare when sold player is bought back again

* #1624 release_notes.md

* new match event 818- player are brothers

* new match event ids

* WorldDetailLeague.allLeagues

* #347 pre match analysis in team analyzer

* #347 refactoring team analyzer recap table

* #347 SquadInfo

* #347 SquadInfo column header

* #347 download squad info of all teams in analyzer

* #347 FixedColumnsTable

* #347 recap table reset when selection changed

* #347 team analyser settings

* #347 UserColumnsTable.loadModel does not reset isDisplay on first start

* #347 release_notes.md

* #1718 remove training formula settings

* #1288 new column HTMS-28 in player overview

* #1288 new column HTMS in player overview

* #1753 ModuleManager.firstStart remove transfer module from auto startup modules

* #1753 ModuleManager.firstStart remove transfer module from auto startup modules

* #1760 fix release_notes.md

* #1755 remove transfer test

* #1448 fix tsi column restore column width

* #1448 minwidth of status column set to 50 points

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk wsbrenk closed this as completed Jan 19, 2023
tychobrailleur pushed a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
@wsbrenk @tychobrailleur
ho-dev#1760 (ho-dev#1765)
65773b4 
* improve XMLWorldDetailsParser.initWorldDetailsMap if next time the HT access to worlddetails file failes longer than next training week

* ho-dev#1624 fix player compare when sold player is bought back again

* ho-dev#1624 release_notes.md

* new match event 818- player are brothers

* new match event ids

* WorldDetailLeague.allLeagues

* ho-dev#347 pre match analysis in team analyzer

* ho-dev#347 refactoring team analyzer recap table

* ho-dev#347 SquadInfo

* ho-dev#347 SquadInfo column header

* ho-dev#347 download squad info of all teams in analyzer

* ho-dev#347 FixedColumnsTable

* ho-dev#347 recap table reset when selection changed

* ho-dev#347 team analyser settings

* ho-dev#347 UserColumnsTable.loadModel does not reset isDisplay on first start

* ho-dev#347 release_notes.md

* ho-dev#1718 remove training formula settings

* ho-dev#1288 new column HTMS-28 in player overview

* ho-dev#1288 new column HTMS in player overview

* ho-dev#1753 ModuleManager.firstStart remove transfer module from auto startup modules

* ho-dev#1753 ModuleManager.firstStart remove transfer module from auto startup modules

* ho-dev#1760 fix release_notes.md

* ho-dev#1755 remove transfer test

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
tychobrailleur pushed a commit to tychobrailleur/HO-t that referenced this issue Sep 16, 2023
@wsbrenk @tychobrailleur
ho-dev#1448 player table column format (ho-dev#1769)
e160f62 
* improve XMLWorldDetailsParser.initWorldDetailsMap if next time the HT access to worlddetails file failes longer than next training week

* ho-dev#1624 fix player compare when sold player is bought back again

* ho-dev#1624 release_notes.md

* new match event 818- player are brothers

* new match event ids

* WorldDetailLeague.allLeagues

* ho-dev#347 pre match analysis in team analyzer

* ho-dev#347 refactoring team analyzer recap table

* ho-dev#347 SquadInfo

* ho-dev#347 SquadInfo column header

* ho-dev#347 download squad info of all teams in analyzer

* ho-dev#347 FixedColumnsTable

* ho-dev#347 recap table reset when selection changed

* ho-dev#347 team analyser settings

* ho-dev#347 UserColumnsTable.loadModel does not reset isDisplay on first start

* ho-dev#347 release_notes.md

* ho-dev#1718 remove training formula settings

* ho-dev#1288 new column HTMS-28 in player overview

* ho-dev#1288 new column HTMS in player overview

* ho-dev#1753 ModuleManager.firstStart remove transfer module from auto startup modules

* ho-dev#1753 ModuleManager.firstStart remove transfer module from auto startup modules

* ho-dev#1760 fix release_notes.md

* ho-dev#1755 remove transfer test

* ho-dev#1448 fix tsi column restore column width

* ho-dev#1448 minwidth of status column set to 50 points

Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsbrenk wsbrenk

Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
2 participants
@tychobrailleur @wsbrenk