Build is not verifiable

[Giszmo]

I tried to reproduce the 1.8.1 build but get a very different result when running ./gradlew clean build. 7.8MB vs. 5.9MB of the Playstore release for a start. Am I looking into the right file at mobile/build/outputs/apk/orginal/release/mobile-orginal-release.apk or would it spit out another one if it wouldn't fail trying to lint the code?

> Task :mobile:lint FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':mobile:lint'.
> Lint found errors in the project; aborting build.
  
  Fix the issues identified by lint, or add the following to your build script to proceed with errors:
  ...
  android {
      lintOptions {
          abortOnError false
      }
  }
  ...
  
  The first 3 errors (out of 5) were:
  /tmp/Bitcoin-Wallet/mobile/src/main/java/com/bitcoin/wallet/btc/ui/activitys/AddressActivity.kt:136: Error: Overriding method should call super.onActivityResult [MissingSuperCall]
      override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) {
                   ~~~~~~~~~~~~~~~~
  /tmp/Bitcoin-Wallet/mobile/src/main/java/com/bitcoin/wallet/btc/service/BlockchainService.java:270: Error: Overriding method should call super.onBind [MissingSuperCall]
      public IBinder onBind(final Intent intent) {
                     ~~~~~~
  /tmp/Bitcoin-Wallet/mobile/src/main/java/com/bitcoin/wallet/btc/ui/activitys/SweepWalletActivity.kt:114: Error: Overriding method should call super.onActivityResult [MissingSuperCall]
      public override fun onActivityResult(requestCode: Int, resultCode: Int, intent: Intent?) {
                          ~~~~~~~~~~~~~~~~
  


* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.4.1/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 10m 18s

[hoanghiephui]

Thanks for report. I will check soon Vào Th 7, 23 thg 11, 2019 lúc 5:11 CH Leo Wandersleb < notifications@github.com> đã viết:

I tried to reproduce the 1.8.1 build but get a very different result when running ./gradlew clean build. 7.8MB vs. 5.9MB of the Playstore release for a start. Am I looking into the right file at mobile/build/outputs/apk/orginal/release/mobile-orginal-release.apk or would it spit out another one if it wouldn't fail trying to lint the code? > Task :mobile:lint FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':mobile:lint'. > Lint found errors in the project; aborting build. Fix the issues identified by lint, or add the following to your build script to proceed with errors: ... android { lintOptions { abortOnError false } } ... The first 3 errors (out of 5) were: /tmp/Bitcoin-Wallet/mobile/src/main/java/com/bitcoin/wallet/btc/ui/activitys/AddressActivity.kt:136: Error: Overriding method should call super.onActivityResult [MissingSuperCall] override fun onActivityResult(requestCode: Int, resultCode: Int, data: Intent?) { ~~~~~~~~~~~~~~~~ /tmp/Bitcoin-Wallet/mobile/src/main/java/com/bitcoin/wallet/btc/service/BlockchainService.java:270: Error: Overriding method should call super.onBind [MissingSuperCall] public IBinder onBind(final Intent intent) { ~~~~~~ /tmp/Bitcoin-Wallet/mobile/src/main/java/com/bitcoin/wallet/btc/ui/activitys/SweepWalletActivity.kt:114: Error: Overriding method should call super.onActivityResult [MissingSuperCall] public override fun onActivityResult(requestCode: Int, resultCode: Int, intent: Intent?) { ~~~~~~~~~~~~~~~~ * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/5.4.1/userguide/command_line_interface.html#sec:command_line_warnings BUILD FAILED in 10m 18s — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15?email_source=notifications&email_token=ACTWUC5QH56T5QIANMRAJ73QVD6U3A5CNFSM4JQZQLQ2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H3RTB7Q>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACTWUC2SKCGX7EL7QLP5ABDQVD6U3ANCNFSM4JQZQLQQ> .

-- *Thanks and regards!* T: 0983 848 849 E: hoanghiep.hui@gmail.com Google Play: https://play.google.com/store/apps/dev?id=5543014516084274398

[Giszmo]

Any news on this? I published my project meanwhile and this is my full analysis of your wallet.

[Giszmo]

3.5 months later ... any news from your side? Should we re-evaluate?

[Giszmo]

ping

[emanuelb]

They stopped publishing source-code for a while: #16

[Giszmo]

We marked them fake in July already. Not sure if the ratings are all bought or how they keep at 4.2 stars but the 1* ratings also have many scam accusations.