Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rx disposable #52

Merged
merged 8 commits into from
Feb 2, 2022

Conversation

jopmiddelkamp
Copy link
Contributor

I've added a reactive disposable mixin to make it easier to dispose of stream listeners. With this mixin, there is no need anymore to store and close stream subscriptions for simple stream listeners.

@codecov
Copy link

codecov bot commented Dec 4, 2021

Codecov Report

Merging #52 (e1d309b) into master (d2490c5) will decrease coverage by 0.85%.
The diff coverage is 0.00%.

❗ Current head e1d309b differs from pull request most recent head 9cc316f. Consider uploading reports for the commit 9cc316f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   95.10%   94.25%   -0.86%     
==========================================
  Files          43       44       +1     
  Lines         552      557       +5     
==========================================
  Hits          525      525              
- Misses         27       32       +5     
Impacted Files Coverage Δ
lib/src/utils/disposable.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2490c5...9cc316f. Read the comment docs.

@jopmiddelkamp
Copy link
Contributor Author

Codecov Report

Merging #52 (e1d309b) into master (d2490c5) will decrease coverage by 0.85%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   95.10%   94.25%   -0.86%     
==========================================
  Files          43       44       +1     
  Lines         552      557       +5     
==========================================
  Hits          525      525              
- Misses         27       32       +5     

Impacted Files Coverage Δ
lib/src/utils/disposable.dart 0.00% <0.00%> (ø)
Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2490c5...e1d309b. Read the comment docs.

I'll take a look into this later this week.

@hoc081098
Copy link
Owner

Hi @jopmiddelkamp, do you have any updates on this?

@jopmiddelkamp
Copy link
Contributor Author

Hi @jopmiddelkamp, do you have any updates on this?

Hi, sorry I forgot about this PR. I'll add some tests this weekend.

@jopmiddelkamp
Copy link
Contributor Author

jopmiddelkamp commented Jan 27, 2022

Hi @jopmiddelkamp, do you have any updates on this?

Hi @hoc081098, Changed my mind and did it straight away!

Copy link
Owner

@hoc081098 hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jopmiddelkamp 👍

@hoc081098 hoc081098 merged commit a49c8a2 into hoc081098:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants