-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/rx disposable #52
Feature/rx disposable #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 95.10% 94.25% -0.86%
==========================================
Files 43 44 +1
Lines 552 557 +5
==========================================
Hits 525 525
- Misses 27 32 +5
Continue to review full report at Codecov.
|
I'll take a look into this later this week. |
Hi @jopmiddelkamp, do you have any updates on this? |
Hi, sorry I forgot about this PR. I'll add some tests this weekend. |
Hi @hoc081098, Changed my mind and did it straight away! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jopmiddelkamp 👍
I've added a reactive disposable mixin to make it easier to dispose of stream listeners. With this mixin, there is no need anymore to store and close stream subscriptions for simple stream listeners.