fix: alias improper cleanup #1350 (#1457)

hoffstadt · Nov 29, 2021 · 37c6bda · 37c6bda
1 parent 69aeb79
commit 37c6bda
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/DearPyGui/src/core/AppItems/mvAppItem.cpp b/DearPyGui/src/core/AppItems/mvAppItem.cpp
@@ -48,7 +48,7 @@ namespace Marvel {
         if (_dropCallback) Py_DECREF(_dropCallback);
 
         // in case item registry is destroyed
-        if (GContext->started)
+        if (GContext->itemRegistry)
         {
             RemoveAlias(*GContext->itemRegistry, _alias, true);
             CleanUpItem(*GContext->itemRegistry, _uuid);

diff --git a/DearPyGui/src/core/mvContext.cpp b/DearPyGui/src/core/mvContext.cpp
@@ -148,7 +148,8 @@ namespace Marvel {
         mvSubmitCallback([=]() {
             GContext->callbackRegistry->running = false;
             });
-        GContext->future.get();
+        if(GContext->future.valid())
+            GContext->future.get();
         if (GContext->viewport)
             delete GContext->viewport;