Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refcount mess in mvAddCallback() and mvRunCallback() #2282

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

fix: Refcount mess in mvAddCallback() and mvRunCallback() #2282

wants to merge 29 commits into from

Commits on Feb 10, 2024

  1. Dev branch

    @bzczb
    bzczb committed Feb 10, 2024
    Configuration menu
    Copy the full SHA
    4bca26f View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2024

  1. Preparing drag/drop callbacks... haven't compiled anything yet.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    f700e2d View commit details
    Browse the repository at this point in the history

  2. Still setting up callbacks.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e471cac View commit details
    Browse the repository at this point in the history

  3. Remove decrementAppData parameter.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    6ae6f19 View commit details
    Browse the repository at this point in the history

  4. Compiles and runs.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e6d5102 View commit details
    Browse the repository at this point in the history

  5. mvCallbackJob also move-only.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5d94ed5 View commit details
    Browse the repository at this point in the history

  6. mvCallbackJob...

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    c1f823f View commit details
    Browse the repository at this point in the history

  7. mvCallbackJob management.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3f6651b View commit details
    Browse the repository at this point in the history

  8. Fix msLoadingIndicatorCustom.cpp for an updated VC++ compiler.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    cdf4a52 View commit details
    Browse the repository at this point in the history

  9. appData refcounts should be good now.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    e1073a2 View commit details
    Browse the repository at this point in the history

  10. Whoops. Fix the crash.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    0428cec View commit details
    Browse the repository at this point in the history

  11. More typos.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    8efa8f7 View commit details
    Browse the repository at this point in the history

  12. Make sure manual callbacks get None instead of nullptr.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    a5e6909 View commit details
    Browse the repository at this point in the history

  13. Rename mvCallbackSlot -> mvCallbackPoint.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5dc323f View commit details
    Browse the repository at this point in the history

  14. More bugfixes.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    6a3f4c9 View commit details
    Browse the repository at this point in the history

  15. Comments in mvCallbackPoint::set_from_python().

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    5f41ac8 View commit details
    Browse the repository at this point in the history

  16. Drop callback for Linux and MacOS.

    @bzczb
    bzczb committed Feb 11, 2024
    Configuration menu
    Copy the full SHA
    3fb0e0a View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Remove drag-and-drop stuff for now, for a pure i2036 fix. 

    Something was wrong with the vector init in InsertParser_Block0(), so
that's chopped out too.
    @bzczb
    bzczb committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    3867831 View commit details
    Browse the repository at this point in the history

  2. Remove personal scripts and settings.json for PR.

    @bzczb
    bzczb committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    360432b View commit details
    Browse the repository at this point in the history

  3. Remove personal setup.py changes.

    @bzczb
    bzczb committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    af9460d View commit details
    Browse the repository at this point in the history

  4. Clean up the mvSubmitCallback([](mvAddCallback(...))). 

    Rename mvAddCallback() -> mvAddCallbackJob(), mvRunCallback() -> mvRunCallbackJob().
Moved the burden of the overloading to mvCallbackWithData, it's cleaner.

(cherry picked from commit 16b4bfe)
    @bzczb
    bzczb committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    a25e6fe View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Rename null_to_none() -> nullToNone(). 

    (cherry picked from commit 5069963)
    @bzczb
    bzczb committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    90e084d View commit details
    Browse the repository at this point in the history

  2. Play better with GIL, keeping most of the complexity in mvCallbackJob. 

    Drag and drop still crashes in the demo.

(cherry picked from commit b3d6ad0)
    @bzczb
    bzczb committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    f47fa30 View commit details
    Browse the repository at this point in the history

  3. mvDragPayload now uses UUID to lookup, instead of copying the whole o… 

    …bject.

This may be a bit slower, but it makes resource management much easier.
Drag and drop doesn't crash anymore.

(cherry picked from commit 3e789c7)
    @bzczb
    bzczb committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    cb0a873 View commit details
    Browse the repository at this point in the history

  4. Remove GIL locking from mvPyObjectStrict and mvAppItem. 

    (cherry picked from commit 05e0c7e)
    @bzczb
    bzczb committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4f53b4c View commit details
    Browse the repository at this point in the history

  5. Don't leak callbacks!! 

    (cherry picked from commit afad663)
    @bzczb
    bzczb committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    fb6cd92 View commit details
    Browse the repository at this point in the history

  6. Fix a few more leaks relating to PyDict_SetItemString(). 

    (cherry picked from commit 42e2f2a)
    @bzczb
    bzczb committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    90141ec View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. Missing include in mvPyUtils.h broke Linux build. 

    (cherry picked from commit 4ca18d5)
    @bzczb
    bzczb committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    119dda3 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. Fix some use-after-free in item handlers. 

    (cherry picked from commit 2139920)
    @bzczb
    bzczb committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a9346c1 View commit details
    Browse the repository at this point in the history