Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with closing the modal window #26

Closed
arctic-hare opened this issue Aug 4, 2021 · 4 comments
Closed

Issue with closing the modal window #26

arctic-hare opened this issue Aug 4, 2021 · 4 comments

Comments

@arctic-hare
Copy link

Hi! I'm using your component in my app. In the modal window, I use forms and there is a problem if the user highlights the content of the form with a mouse. The modal window closes as soon as the user releases the left button of the mouse outside it. Could the logic of the closing modal window be changed, so it closes when "mouseup" and "mousedown" events are triggered outside the modal window.
@hoiheart
Copy link
Owner

hoiheart commented Aug 5, 2021

Hi 😀
I think you can work it out with closeClickDimmed Property.
(https://github.com/hoiheart/vue-universal-modal#propsoptions)

<Modal
  v-model="isShow"
  :close="closeModal"
  :closeClickDimmed="false"
>

Is that what you want?

@arctic-hare
Copy link
Author

No. I accurately described the problem, I can send a video later where this inconvenience will be shown in UI

hoiheart added a commit that referenced this issue Aug 9, 2021
@hoiheart
fix: Change background mouse click event to mousedown, mouseup #26
f184d25
hoiheart added a commit that referenced this issue Aug 9, 2021
@hoiheart
Merge pull request #27 from hoiheart/develop
2253c04 
fix: Change background mouse click event to mousedown, mouseup #26
github-actions bot pushed a commit that referenced this issue Aug 9, 2021
@semantic-release-bot
chore(release): 1.1.3 [skip ci]
564b806 
### [1.1.3](v1.1.2...v1.1.3) (2021-08-09)

### Bug Fixes

* Change background mouse click event to mousedown, mouseup [#26](#26) ([f184d25](f184d25))
@hoiheart
Copy link
Owner

hoiheart commented Aug 9, 2021

@arctic-hare
I think I understood your problem, so I fixed it. (v1.1.3)
Can you check it out here?
https://hoiheart.github.io/vue-universal-modal/demo/index.html

@arctic-hare
Copy link
Author

Hi
Yes, the problem has been resolved. Thanks a lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arctic-hare @hoiheart