Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Php7 signature #2

Merged
merged 4 commits into from May 23, 2018
Merged

Php7 signature #2

merged 4 commits into from May 23, 2018

Commits on May 23, 2018

  1. Adjust method signatures to match parent 

    to prevent php warnings in php_error.log
    @ssahara
    ssahara committed May 23, 2018
    Copy the full SHA
    8f95b17 View commit details
    Browse the repository at this point in the history

  2. omit the PHP closing tag at the end of the file 

    This prevents accidental whitespace or new lines being added after the
PHP closing tag, which may cause unwanted effects because PHP will start
output buffering when there is no intention from the programmer to send
any output at that point in the script.
see http://php.net/manual/en/language.basic-syntax.phptags.php
    @ssahara
    ssahara committed May 23, 2018
    Copy the full SHA
    0ac59e0 View commit details
    Browse the repository at this point in the history

  3. remove superfluous code

    @ssahara
    ssahara committed May 23, 2018
    Copy the full SHA
    1185fce View commit details
    Browse the repository at this point in the history

  4. add code header with short description

    @ssahara
    ssahara committed May 23, 2018
    Copy the full SHA
    792baf2 View commit details
    Browse the repository at this point in the history