Agent: Support exporters with loopback host #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an Exporter and the Hub run on the same host and the Exporter connects to the hub via localhost, then the host of the Place is the loopback address for every agent. This prevents agents from connecting if they are on a remote host. Fixed by replacing the host of the Place with the host of the Hub, if the host of the Place is the loopback address. I considered replacing the host in `/api/v1/places` on the Hub, but then clients would get different responses based on their source IP address, which doesn't work well with HTTP caching, if it will ever be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Exporter and the Hub run on the same host and the Exporter
connects to the hub via localhost, then the host of the Place is the
loopback address for every agent. This prevents agents from connecting
if they are on a remote host.
Fixed by replacing the host of the Place with the host of the Hub, if
the host of the Place is the loopback address.
I considered replacing the host in
/api/v1/placeson the Hub, but thenclients would get different responses based on their source IP address,
which doesn't work well with HTTP caching, if it will ever be used.