Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UXUI-78 - Adding styling for inputs #36

Merged
merged 4 commits into from
Jul 7, 2015
Merged

UXUI-78 - Adding styling for inputs #36

merged 4 commits into from
Jul 7, 2015

Conversation

jodiedoubleday
Copy link
Contributor

What does this PR do? (please provide any background)

  • We have a few PR's in now to add or use input into the toolkit. These have been created but don't look particularly great.

What tests does this PR have?

None

How can be this tested?

  • Run the UI toolkit
  • grunt docs is your best bet, edit the HTML in dev tools and add an input to the page <input type="text" /> for example
  • check ho it looks - not great
  • add class="component-input" to the input
    It should no look good.

Screenshots / Screencast

Input

What gif best describes how you feel about this work?

Input

(it makes me sad that a lot of HX developers wont understand this GIF)

Developer Definition of Done/Quality Checklist (for PR author to complete BEFORE code review):

Software Engineer or Developer review:

  • I’ve witnessed the work behaving as expected (this could be on the authors machine or screencast).
  • I’ve checked for coding anti-patterns.
  • I’ve checked for appropriate test coverage.
  • I’ve run all the tests locally and they pass.

Software Engineer or project guru review:

  • I’ve witnessed the work behaving as expected (this could be on the authors machine or screencast).
  • I’ve checked for coding anti-patterns.
  • I’ve checked for appropriate test coverage.
  • I’ve run all the tests locally and they pass.

@robhuzzey
Copy link
Contributor

Taking SE/DEV

@robhuzzey
Copy link
Contributor

Looking at this at first glance, it looked like quite a few files were changed but they are actually auto generated (dist/ui-toolkit.standalone.js as an example).

I've reviewed the less files but I'd suggest removing the auto-generated files from the repo, stick them on .gitignore as they are not really part of the codebase.

@robhuzzey
Copy link
Contributor

+1 from me

@jackdclark
Copy link
Contributor

Yes sir 👍

jodiedoubleday pushed a commit that referenced this pull request Jul 7, 2015
UXUI-78 - Adding styling for inputs
@jodiedoubleday jodiedoubleday merged commit 6fbc44c into master Jul 7, 2015
@jodiedoubleday jodiedoubleday deleted the UXUI-278 branch July 7, 2015 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants