Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.7 problems #82

Closed
alexhanh opened this issue Oct 13, 2014 · 5 comments
Closed

1.0.7 problems #82

alexhanh opened this issue Oct 13, 2014 · 5 comments

Comments

@alexhanh
Copy link

Hey! Just updated from 1.0.6 to 1.0.7 and something went wrong:

1.0.7:

Loading development environment (Rails 4.1.6)
2.1.1 :001 > Date.current.holiday?
NoMethodError: undefined method `holiday?' for Mon, 13 Oct 2014:Date

Seems like Holidays isn't loaded all.

1.0.6:

Loading development environment (Rails 4.1.6)
2.1.1 :001 > Date.current.holiday?
 => false 

I simply have this in my Gemfile:

gem 'holidays'

I skimmed through the change history since 1.0.6 and couldn't find anything relevant that would affect loading of Holidays.

@spannerinworks
Copy link

We're having the same issue. It is working if we clone master and use the gem source directly via path in our Gemfile. Perhaps a problem with the gem packaging?

@alexhanh
Copy link
Author

@spannerinworks Seems like changes were made to Gem packaging right after the 1.0.6 release, which resonates with what you have experienced.

Here's the commit 762dda2.

@alexdunae
Copy link
Contributor

Thanks for reporting. I'll get this sorted out today.

Dialect // 778-992-2229 // dialect.ca

On Oct 13, 2014, ing. at 1:53 AM, Alexander Hanhikoski notifications@github.com wrote:

Hey! Just updated from 1.0.6 to 1.0.7 and something went wrong:

1.0.7:

Loading development environment (Rails 4.1.6)
2.1.1 :001 > Date.current.holiday?
NoMethodError: undefined method `holiday?' for Mon, 13 Oct 2014:Date
1.0.6:

Loading development environment (Rails 4.1.6)
2.1.1 :001 > Date.current.holiday?
=> false
I simply have this in my Gemfile:

gem 'holidays'

Reply to this email directly or view it on GitHub.

@weshatheleopard
Copy link

Here, found it.

The file data.tar.gz in the gem archive (holidays-1.0.7.gem) is completely empty.

You need to re-create the gem.

@alexdunae
Copy link
Contributor

New version is alive. Thanks for submitting your reports. I'm not sure how it ever built successfully before, to be honest, since the required files were never specified in the past. I guess that's what Jeweler was doing.

Cheers...

Murphydbuffalo pushed a commit to Murphydbuffalo/holidays that referenced this issue Sep 21, 2021
Remove before_install from travis config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants