Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and definition syntax documentation for clarity #166

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

ppeble
Copy link
Member

@ppeble ppeble commented Feb 21, 2016

Opening this up for feedback. Felt that the current READMEs were not clear enough. There's a lot of info but I felt that spelling it all out for the definitions was worth it. I don't see this format changing much and so I think documenting it is safe as a time investment.

If I don't hear anything back this week I'll just merge it in.

@ttwo32
Copy link
Member

ttwo32 commented Feb 22, 2016

It,s a kind explanation. 👍
I felt test is very very important too. 😄

@ppeble
Copy link
Member Author

ppeble commented Feb 26, 2016

@ttwo32 Thank you!

ppeble added a commit that referenced this pull request Feb 26, 2016
Update README and definition syntax documentation for clarity
@ppeble ppeble merged commit d597c3f into holidays:master Feb 26, 2016
@ppeble ppeble deleted the documentation branch February 26, 2016 21:55
Murphydbuffalo pushed a commit to Murphydbuffalo/holidays that referenced this pull request Sep 21, 2021
add "Lunes de Pascua Granada" to Catalunya holidays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants