Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FULL_DEFINITIONS_PATH for require #257

Merged
merged 1 commit into from Jan 25, 2017
Merged

Use FULL_DEFINITIONS_PATH for require #257

merged 1 commit into from Jan 25, 2017

Conversation

burke
Copy link
Contributor

@burke burke commented Jan 21, 2017

This prevents NameErrors from iterating through the whole LOAD_PATH.

@burke
Use FULL_DEFINITIONS_PATH for require
eeaf65b 
This prevents NameErrors from iterating through the whole LOAD_PATH
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 99.453% when pulling eeaf65b on burke:master into 4b58e1e on holidays:master.

@coveralls
Copy link

coveralls commented Jan 21, 2017 •
edited

Coverage Status

Coverage remained the same at 99.484% when pulling eeaf65b on burke:master into 4b58e1e on holidays:master.

@ttwo32
Copy link
Member

ttwo32 commented Jan 22, 2017

@burke Hi @burke !! Thanks for your contribution.
This PR looks good to me.:)
But Jruby's test was failed by bundler's bug.
Please wait a few days.
I appreciate your cooperation.

@ttwo32
Copy link
Member

ttwo32 commented Jan 25, 2017

Bundler's bug has been fixed finally.
All tests are fine.I am going to merge this.:)

@ttwo32 ttwo32 merged commit 4a47918 into holidays:master Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@burke @coveralls @ttwo32