Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image upload is broken again from 2.2.1+ #1013

Closed
ultra-pool opened this issue Oct 28, 2021 · 11 comments
Closed

Image upload is broken again from 2.2.1+ #1013

ultra-pool opened this issue Oct 28, 2021 · 11 comments

Comments

@ultra-pool
Copy link
Contributor

ultra-pool commented Oct 28, 2021

2.2.0 PR was pushed and the image upload was working good. Now after upload to 2.2.1 its been broken and set back to 2MB. 2.2.2 is the same way. This has cause a lot of problems with in the community.

https://github.com/bitholla/hollaex-kit/blob/master/web/src/utils/icon.js#L131
The PR i push had.
const sizeLimit = sizeLimitInMB * 1024 * 10;
#981
Look like it was changed back to which put the file size back to 2MB.
const sizeLimit = sizeLimitInMB * 1024 * 1024;

@abeikverdi
Copy link
Collaborator

1024 * 10 is 10 KB byte. This should be in MB. Your commit resulted in a much smaller file size which is not acceptable and expected by any end user.

@ultra-pool
Copy link
Contributor Author

ultra-pool commented Oct 29, 2021

const sizeLimit = sizeLimitInMB * 10240 * 10240;
Would this be a better fit for it?

const sizeLimit = sizeLimitInMB * 1024 * 10;
I wonder why it worked fine on my DIY for 10MB. Unless docker didn't completely update the web after being applied?

@ultra-pool
Copy link
Contributor Author

Would be this better suited for 10MB image upload fix? I have not tested as I needed to reformat my server. But I will test on a clean server. Found that docker was not applying the new image after building.

from const sizeLimit = sizeLimitInMB * 1024 * 1024;
To const sizeLimit = sizeLimitInMB * 5120 * 5120;

@abeikverdi
Copy link
Collaborator

it should be for 10mb:
const sizeLimit = sizeLimitInMB * 1024 * 1024 * 10;

@ultra-pool
Copy link
Contributor Author

ultra-pool commented Nov 2, 2021

I see. Can you push that fix? Or do I need to open another PR? My DIY server docker crashed and had to reformat and now I cant redo our test server. It kept saying user already exists and server name already used for our testing. It won't take my user name and password and pull the info from our testing hollaex account.

@ultra-pool
Copy link
Contributor Author

ultra-pool commented Nov 3, 2021

#1026

I was not able to test this. Since my DIY hollaex-kit is down ATM. Please verify and add. Thank you for your help abeikverdi

@ultra-pool
Copy link
Contributor Author

Closing since this is in the works. Thank you.

@ultra-pool ultra-pool reopened this Nov 11, 2021
@ultra-pool
Copy link
Contributor Author

ultra-pool commented Nov 11, 2021

I see that was not added to master from dev so reopening this issue as our whole community is bitching about this and closing account and/or just not using the exchange because of this issue. @abeikverdi
Will close this issue once added.

@abeikverdi
Copy link
Collaborator

This issue is resolved in v2.2.3 using KYC plugin v6. The KYC related stuff are fully now managed by the KYC plugin v6.

@ultra-pool
Copy link
Contributor Author

Thank you. I will update and test.

@ultra-pool
Copy link
Contributor Author

ultra-pool commented Nov 11, 2021

@abeikverdi kYC v3 plugin gives errors when trying to install. Im not the only one having this error. Please see the discord chat for another user that sent a screenshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants