KYC wording & Image upload fix to 9.9MB +/- #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeikverdi
requested changes
Oct 13, 2021
web/src/utils/icon.js
Outdated
|
|
||
| export const checkFileSize = (file) => { | ||
| if (file && file.size) { | ||
| const sizeLimit = sizeLimitInMB * 1024 * 1024; | ||
| const sizeLimit = sizeLimitInMB * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024 * 1024; |
There was a problem hiding this comment.
I do not understand as this is not for a coin currency using a a lot of zeros. Please send a example or please edit the code ion the PR so i see what you are referring to.
There was a problem hiding this comment.
its got a repeated multiplication. Cleaner to use power function instead.
|
This was the only way it worked. The plugin config has no settings for this image upload size. |
abeikverdi
reviewed
Oct 16, 2021
|
I will try 1024 * 10 and not 10240 and see if it will work on the DIY. We are needing atleast 10MB max. |
|
Changed 1024 * 10 and not 10240 and it worked on our DIY test server. Once approved can we get this pushed or our Pro Cloud asap? Thank you. |
abeikverdi
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and tested the Image bug for the KYC when submitting images. It was maxed to 2MB or less and word say "Network error". Now its been tested up to 9.7MB with all 3 images in PNG and JPG tested. You may test this for yourself at [https://trade.simpledex.net](Simpledex is my DIY testing ground for our Pro Cloud project) Once Bitholla Dev's have tested ill need these edits pushed to our Pro cloud asap. You may contact me via discord 饾暯饾暟饾暬饾暫#5278
Here's 5 screen shots Iv taken of the images uploaded via KYC plugin.
Blue Admin panel image preview = https://filerepo.io/index.php/s/TwPNRcz8XyRXWS6
Files in storage w/size's = https://filerepo.io/index.php/s/CHqWaeGy4dTEaAe
KYC wording change 1 = https://filerepo.io/index.php/s/q4LoDKnfS78Ntst
KYC wording change 2 = https://filerepo.io/index.php/s/QzPXmKGff9MtwAw
KYC wording change 3 = https://filerepo.io/index.php/s/55KA5ftXN7xxRkK