[1.20.4] FakePlayer not spawning

[enimaloc]

I've updated to version 1.20.4 via a self-built minestom-ce on the 1_20_4 branch.

I try to make a FakePlayer appear with:

        MinecraftServer.getGlobalEventHandler().addListener(PlayerSpawnEvent.class, e -> {
            System.out.println("e = " + e);
            FakePlayer.initPlayer(UUID.randomUUID(), "Child", fp -> {
                fp.setInstance(container, new Pos(0, 42, 0));
                fp.setRespawnPoint(new Pos(0, 42, 0));
                fp.spawn();
                System.out.println("fp = " + fp);
            });
        });

So, e is printed e = net.minestom.server.event.player.PlayerSpawnEvent@7926d4ab.
But fp is not printed and the fake player does not appear.

[enimaloc]

With this piece of code I log all player in PLAY and CONFIGURATION state:

MinecraftServer.getSchedulerManager().scheduleTask(() -> {  
    System.out.println("MinecraftServer.getConnectionManager().getOnlinePlayers().size() = " + MinecraftServer.getConnectionManager().getOnlinePlayerCount());  
    for (Player player : MinecraftServer.getConnectionManager().getPlayers(ConnectionState.PLAY, ConnectionState.CONFIGURATION)) {  
        System.out.printf("player = %s, state = %s%n", player.getUsername(), player.getPlayerConnection().getClientState());  
    }  
}, TaskSchedule.immediate(), TaskSchedule.tick(20));  

Now, I get my fake player in state HANDSHAKE but when I get I query only PLAY and CONFIGURATION state ?

MinecraftServer.getConnectionManager().getOnlinePlayers().size() = 1  
player = Child, state = HANDSHAKE  
player = enimaloc, state = PLAY  

Anyway, It seems my fake player stuck in HANDSHAKE state.

[mworzala]

Should be fixed now. Note that you should not call setInstance in the spawn callback. FakePlayers go through the normal config->play sequence meaning you should use the config event to configure the spawning instance.