Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying ReutersBridge #5

Merged
merged 52 commits into from
Aug 9, 2020
Merged

Modifying ReutersBridge #5

merged 52 commits into from
Aug 9, 2020

Conversation

csisoap
Copy link

@csisoap csisoap commented Aug 5, 2020

  • Add UID for each article.
  • Add images, full details of article and author's name.
  • Refactor some code.

P/s: The feed may takes time to instantiate or when the cache refreshed and because for every article, it need to get the full detail of that.

image

@csisoap
Copy link
Author

csisoap commented Aug 8, 2020

@hollowleviathan

@hollowleviathan
Copy link
Owner

hollowleviathan commented Aug 9, 2020

Could you please run phpcbf on your bridges/ReutersBridge.php, use tabs instead of spaces, and use array() instead of [] to conform with the RSS-Bridge style guide?

I've enabled the Travis CI that auto-runs on the MR and points out what changes RSS-Bridge wants

@csisoap
Copy link
Author

csisoap commented Aug 9, 2020

I've ran PHPCBF on the code, change all [] into array() and it still fail. The code passed the syntax test but not indentation/whitespace test.

UPDATE: The code has passed all test. I've tabs all the code and then PHPCBF change back to spaces, i don't know why?

@hollowleviathan hollowleviathan merged commit b600c35 into hollowleviathan:reuters Aug 9, 2020
hollowleviathan pushed a commit that referenced this pull request Oct 8, 2020
[ReutersBridge] Add all article from 'Editor\'s Highlight' to the feed, more categories, author name, full article text.
hollowleviathan pushed a commit that referenced this pull request Oct 20, 2020
[ReutersBridge] Add all article from 'Editor\'s Highlight' to the feed, more categories, author name, full article text.
hollowleviathan pushed a commit that referenced this pull request Dec 30, 2020
[ReutersBridge] Add all article from 'Editor\'s Highlight' to the feed, more categories, author name, full article text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants