Add 'quiet' command #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'quiet' command lets you copy to the clipboard without echo
|
I think this looks pretty good, thanks! One thing: when I think about how I'd use this, I'd think to myself "I want to copy this" and not "I want to quiet this". Can you change the |
|
Agreed. Latest commit just changes the name to 'copy'. Thanks for your time.. Happy with first successful pull request! |
|
👍! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'quiet' command lets you copy to the clipboard without echo. This can be useful if the item information is somewhat private. It will still echo an error if the item is not found.
Tests
I wasn't able to find a test for this feature. Since nothing is echoed I can't grep on anything like the other tests. Tried grep '^$' but that didn't work. Seems to work on my system however.
Disclaimer
This is my first ruby code and honestly just wanted to do a little something to get used to the syntax and project setup. The code I added is pretty much a duplicate of the 'echo' function with little changes. Opening this pull request so you can give me a little feedback and merge if you think it can be useful.