Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Passphrase manager #1122

Merged
merged 9 commits into from
Mar 19, 2019
Merged

Passphrase manager #1122

merged 9 commits into from
Mar 19, 2019

Conversation

lucksus
Copy link
Collaborator

@lucksus lucksus commented Mar 15, 2019

Screenshot from 2019-03-15 18-05-08

  • I have added a summary of my changes to the changelog

thedavidmeister
thedavidmeister approved these changes Mar 17, 2019
View reviewed changes
Copy link
Contributor

@thedavidmeister thedavidmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@maackle
Copy link
Member

maackle commented Mar 18, 2019 •
edited
Loading

Will this eventually address the event of a power cycle, where the machine can't join the network again without human input? Oh yeah, I see that's the next item in the tree.

@lucksus lucksus requested a review from neonphog March 18, 2019 17:36
@lucksus
Copy link
Collaborator Author

lucksus commented Mar 18, 2019

Hey @neonphog, I would love to have you have a quick look over this. Note that I'm currently using an insecure SecBuf because of the size constraint currently still present for secure ones. I think we need to change this before beta.

@thedavidmeister
Copy link
Contributor

Note that I'm currently using an insecure SecBuf

mm i wondered about that

neonphog
neonphog reviewed Mar 19, 2019
View reviewed changes
conductor_api/src/conductor/passphrase_manager.rs

let pm_clone = pm.clone();

thread::spawn(move || loop {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to need to do an audit of system threads at some point... they should probably mostly be moved into some kind of pool executor scheme.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@neonphog
Copy link
Contributor

Note that I'm currently using an insecure SecBuf

#1017 strikes again!

neonphog
neonphog approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! nice work

@lucksus lucksus merged commit 360880a into develop Mar 19, 2019
@zippy zippy deleted the passphrase-manager branch July 5, 2019 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zippy zippy zippy approved these changes

@thedavidmeister thedavidmeister thedavidmeister approved these changes

@neonphog neonphog neonphog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lucksus @maackle @thedavidmeister @neonphog @zippy