This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
Adds conversions from json string to generic Results #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemolding
requested review from
thedavidmeister,
philipbeadle,
zippy,
lucksus and
maackle
willemolding
commented
Jun 3, 2019
| @@ -449,4 +501,24 @@ pub mod tests { | |||
| String::from(JsonString::from(RawString::from(1))), | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn result_from_json_string() { | |||
There was a problem hiding this comment.
@philipbeadle this should be very similar to how you want to use it in P&P
willemolding
changed the title
philipbeadle
approved these changes
Jun 3, 2019
|
Great work! This solves exactly the problem I ran into with both HoloFuel and the App Spec tests, when trying to serialize a Result<...> response for the hdk::send/receive round-trip. Looking forward to seeing this merged! |
…l-conversions-from-json-string-to-result-option
|
FYI, the branch |
pjkundert
approved these changes
Jun 3, 2019
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Adds some of the missing conversion implementations for JsonString. It is now possible to
try_intoa result type directly from a JsonString.This was NOT possible before meaning bridge calls were really difficult to get right without resorting to serde_json::Value.
It needs extra implementations for all variations of result containing a
Stringsince this no longer implementsInto<JsonString>changelog
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)