This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
core: Rewrite await!(future) to future.await
#1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves holochain#1723 by migrating away from the old syntax The other change this commit makes is removing `#![feature(await_macro)]` invocations
|
I just found out that the make script sets an override for nightly-2019-07-14. That would explain why nobody is running into this. |
|
A cursory search reveals that there are 8 different places that would need to be updated to a new version of rust to use after this change. It seems like this PR is then blocked on determining a new version of nightly to stick with that's after 2019-7-30. I imagine that's low priority for the team. Hmmm... |
|
Oh never mind, 2019-07-14 supports the new syntax as well. |
willemolding
approved these changes
Oct 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This resolves #1723 by migrating away from the old syntax.
The other change this commit makes is removing
#![feature(await_macro)]invocations.changelog
The only "breaking change" this PR causes is change our minimum supported nightly to 2019-05-08. This doesn't seem changelog worthy to me.
Please check one of the following, relating to the CHANGELOG-UNRELEASED.md
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)