Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Compilation fails on nightlies since 2019-7-30 due to old await syntax #1723

Closed
timotree3 opened this issue Sep 27, 2019 · 6 comments · Fixed by #1726
Closed

Compilation fails on nightlies since 2019-7-30 due to old await syntax #1723

timotree3 opened this issue Sep 27, 2019 · 6 comments · Fixed by #1726

Comments

@timotree3
Copy link
Collaborator

rust-lang/rust#62293 removed support for the await! syntax that we're currently using. The new .await syntax has worked since nightly-2019-05-08. It seems like it'd be safe to update the syntax we use.

@timotree3
Copy link
Collaborator Author

I'm working on a PR to update our uses now.

timotree3 added a commit to timotree3/holochain-rust that referenced this issue Sep 27, 2019
This resolves holochain#1723 by migrating away from the old syntax

The other change this commit makes is removing
`#![feature(await_macro)]`
invocations
@thedavidmeister
Copy link
Contributor

@timotree3 you need to use holonix, which contains the exact rust versions that are compatible with all relevant crates https://github.com/holochain/holonix

@timotree3
Copy link
Collaborator Author

Personally, I can't use the nix install option because I don't have the disk space. I'm not too worried about closing this because #1726 will fix it soon. :-) On a procedural note though, it doesn't actually seem to me like this issue has been resolved.

@thedavidmeister
Copy link
Contributor

@timotree3 ok, is the refactor going to be compatible with the rust shipped in holonix?

@timotree3
Copy link
Collaborator Author

Yep. (Correct me if I'm wrong) but I believe Holonix uses 2019-07-14. The new syntax has been supported since 2019-05-08

@thedavidmeister
Copy link
Contributor

@timotree3 ok sweet, well carry on then :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants