Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Move self-holding logic from core to Sim2h to fix consistency model problems #1990

Merged
merged 8 commits into from Dec 18, 2019

Conversation

lucksus
Copy link
Collaborator

@lucksus lucksus commented Dec 17, 2019

PR summary

These changes replace merging the authoring list into the gossip list with code in sim2h_worker that makes the instance hold everything it's authoring.

This has two benefits:

  1. Always merging the authoring into the gossip list was the only code in core that assumes a full-sync DHT. We don't want that assumption in core - if we are in a full-sync or sharded DHT should be only sim2h's concern.
  2. By having core hold it's own entries explicitly we are true to the assumption in Hachiko - namely that we can tell by the core action HoldAspect if a node is holding something.

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

@thedavidmeister thedavidmeister merged commit d150033 into develop Dec 18, 2019
@thedavidmeister thedavidmeister mentioned this pull request Dec 18, 2019
2 tasks
@zippy zippy deleted the cleanup-holding-gossip-logic branch January 3, 2020 22:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants