Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove regex #2133

Merged
merged 7 commits into from Mar 2, 2020
Merged

Remove regex #2133

merged 7 commits into from Mar 2, 2020

Conversation

@AshantiMutinta
Copy link
Contributor

AshantiMutinta commented Feb 25, 2020

PR summary

Removed regex backend

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Copy link
Contributor

neonphog left a comment

couple questions about more cleanups, but all the changes here look good 👍

AshantiMutinta and others added 3 commits Feb 29, 2020
@zippy
zippy approved these changes Mar 2, 2020
@zippy zippy merged commit a3f0e9c into develop Mar 2, 2020
5 of 6 checks passed
5 of 6 checks passed
ci/circleci: app-spec-tests-sim2h CircleCI is running your tests
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: cli-tests Your tests passed on CircleCI!
Details
ci/circleci: fmt Your tests passed on CircleCI!
Details
ci/circleci: stress-tests-sim2h Your tests passed on CircleCI!
Details
ci/circleci: wasm-conductor-tests Your tests passed on CircleCI!
Details
@neonphog neonphog deleted the remove_regex branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.