Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Remove regex #2133

Merged
merged 7 commits into from
Mar 2, 2020
Merged

Remove regex #2133

merged 7 commits into from
Mar 2, 2020

Conversation

StaticallyTypedAnxiety
Copy link
Contributor

@StaticallyTypedAnxiety StaticallyTypedAnxiety commented Feb 25, 2020

PR summary

Removed regex backend

testing/benchmarking notes

( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )

followups

( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )

changelog

  • if this is a code change that effects some consumer (e.g. zome developers) of holochain core, then it has been added to our between-release changelog with the format
- summary of change [PR#1234](https://github.com/holochain/holochain-rust/pull/1234)

documentation

Copy link
Contributor

@neonphog neonphog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple questions about more cleanups, but all the changes here look good 👍

@zippy zippy merged commit a3f0e9c into develop Mar 2, 2020
@neonphog neonphog deleted the remove_regex branch March 6, 2020 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants