allow tls keylog #1261
allow tls keylog #1261
Conversation
| /// returns true if we should initialize a tls keylog | ||
| /// based on the `SSLKEYLOGFILE` environment variable | ||
| pub fn use_env_tls_keylog(&self) -> bool { | ||
| self.danger_tls_keylog == "env_keylog" | ||
| } |
There was a problem hiding this comment.
@neonphog why not just make danger_tls_keylog a bool? Making it a string invites people to wonder if it's actually some sort of parameter, but it's really just a flag that requires a magic string to activate.
There was a problem hiding this comment.
@maackle - It feels more enum-y to me though, like we might want to have other keylogging options (network?) in the future, hence the string.
There was a problem hiding this comment.
fyi, this fn in particular is really an internal api... it just so happens the different kitsune_p2p crate (instead of kitsune_p2p_types) needs to use it, hence the pub.
There was a problem hiding this comment.
Ok, I guess I hadn't imagined there being any other future options for this, so this looks good
| /// returns true if we should initialize a tls keylog | ||
| /// based on the `SSLKEYLOGFILE` environment variable | ||
| pub fn use_env_tls_keylog(&self) -> bool { | ||
| self.danger_tls_keylog == "env_keylog" | ||
| } |
There was a problem hiding this comment.
Ok, I guess I hadn't imagined there being any other future options for this, so this looks good
Summary
danger_tls_keylog_path_prefixwhich will write keylog files for quic tls sessionsTODO: