Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move files for integrity zome changes #1324

Merged
merged 11 commits into from
Apr 7, 2022
Merged

Move files for integrity zome changes #1324

merged 11 commits into from
Apr 7, 2022

Conversation

freesig
Copy link
Contributor

@freesig freesig commented Apr 5, 2022 •
edited
Loading

Summary

TODO:

  • CHANGELOG(s) updated with appropriate info
  • Just before pressing the merge button, ensure new entries to CHANGELOG(s) are still under the UNRELEASED heading
  • Move mock_idk to crates folder so it's published.
  • Update the readme for IDK and integrity types.
  • Make minimal version of DnaDef for genesis self check.
  • Do we need zome_info and dna_info. Deferred to future work
  • Double check that sub set of wasmer externs can run.
  • Checks docs.
  • Add read me to mock_idk
  • Land the name for idk and rename all crates.

@freesig freesig force-pushed the integrity branch 5 times, most recently from dc87692 to 0b3a630 Compare April 5, 2022 10:25
thedavidmeister
thedavidmeister approved these changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@thedavidmeister thedavidmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending checklist of changes discussed on the call @freesig

@freesig
Copy link
Contributor Author

freesig commented Apr 7, 2022

I will pull in develop once I have two reviews. It's a long process so I only want to do it once more just before merging

@freesig freesig merged commit 669d9ea into develop Apr 7, 2022
@freesig freesig deleted the integrity branch April 7, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedavidmeister thedavidmeister thedavidmeister approved these changes

@maackle maackle Awaiting requested review from maackle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freesig @thedavidmeister