Remove deny warnings #126
Remove deny warnings #126
Conversation
| @@ -46,7 +46,7 @@ release: tools | |||
|
|
|||
| static: tools docs | |||
| cargo fmt -- --check | |||
| cargo clippy $(FEATURES) | |||
| cargo clippy $(FEATURES) -- -Dwarnings | |||
There was a problem hiding this comment.
Can you add this to the build --all-targets in the test target too? I'm not sure clippy checks everything like benchmarks, etc, right?
There was a problem hiding this comment.
It doesn't recognize the option, and it seems like this is still an open request for Cargo#8424. Yes this might miss some things but I'm not sure what the right solution would be. Maybe we would have to put #![deny(warnings)] in test code?
There was a problem hiding this comment.
This wouldn't be making anything worse though right? Because test/benchmark targets would be built separately and not respect the directive in the lib/bin anyway? So we're making CI more strict and it will definitely check the code we removed the directive from. I'm tempted to leave figuring out erroring on lints for benchmarks as a problem to solve
Summary
As discussed, remove deny warnings and rely on CI to catch warnings. See recommendations from clippy docs
I've also bumped the versions in the same PR so I can release this once the PR is in
TODO: