Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix to prevent accumulation of dist.zip content #300

Merged
merged 1 commit into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
"build": "vite build",
{{#if holo_enabled}}
"build:holo": "VITE_APP_IS_HOLO=true vite build",
"package:holo": "npm run build:holo && cd dist && bestzip ../dist.zip *",
"package:holo": "npm run build:holo && rimraf dist.zip && cd dist && bestzip ../dist.zip *",
{{/if}}
"lint": "eslint --ext .ts,.html . --ignore-path .gitignore && prettier \"**/*.ts\" --check --ignore-path .gitignore",
"format": "eslint --ext .ts,.html . --fix --ignore-path .gitignore && prettier \"**/*.ts\" --write --ignore-path .gitignore",
"package": "npm run build && cd dist && bestzip ../dist.zip *"
"package": "npm run build && rimraf dist.zip && cd dist && bestzip ../dist.zip *"
},
"dependencies": {
"@holochain/client": "{{holochain_client_version}}",
Expand Down
4 changes: 2 additions & 2 deletions templates/lit/web-app/ui/package.json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
"build": "vite build",
{{#if holo_enabled}}
"build:holo": "VITE_APP_IS_HOLO=true vite build",
"package:holo": "npm run build:holo && cd dist && bestzip ../dist.zip *",
"package:holo": "npm run build:holo && rimraf dist.zip && cd dist && bestzip ../dist.zip *",
{{/if}}
"lint": "eslint --ext .ts,.html . --ignore-path .gitignore && prettier \"**/*.ts\" --check --ignore-path .gitignore",
"format": "eslint --ext .ts,.html . --fix --ignore-path .gitignore && prettier \"**/*.ts\" --write --ignore-path .gitignore",
"package": "npm run build && cd dist && bestzip ../dist.zip *"
"package": "npm run build && rimraf dist.zip && cd dist && bestzip ../dist.zip *"
},
"dependencies": {
"@holochain/client": "{{holochain_client_version}}",
Expand Down
5 changes: 3 additions & 2 deletions templates/svelte/web-app/ui/package.json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
"build": "npm run check && vite build",
{{#if holo_enabled}}
"build:holo": "VITE_APP_IS_HOLO=true vite build",
"package:holo": "npm run build:holo && cd dist && bestzip ../dist.zip *",
"package:holo": "npm run build:holo && rimraf dist.zip && cd dist && bestzip ../dist.zip *",
{{/if}}
"check": "svelte-check --tsconfig ./tsconfig.json",
"package": "npm run build && cd dist && bestzip ../dist.zip *"
"package": "npm run build && rimraf dist.zip && cd dist && bestzip ../dist.zip *"
},
"dependencies": {
"@holochain/client": "{{holochain_client_version}}",
Expand All @@ -33,6 +33,7 @@
"@sveltejs/vite-plugin-svelte": "^2.0.2",
"@tsconfig/svelte": "^3.0.0",
"bestzip": "^2.2.0",
"rimraf": "^3.0.2",
"svelte": "^3.55.1",
"svelte-check": "^2.10.3",
"tslib": "^2.4.1",
Expand Down
2 changes: 1 addition & 1 deletion templates/vanilla/example/ui/package.json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"start": "vite --clearScreen false --port $UI_PORT",
"build": "vite build",
"package": "npm run build && cd dist && bestzip ../dist.zip *"
"package": "npm run build && rimraf dist.zip && cd dist && bestzip ../dist.zip *"
},
"dependencies": {
"@holochain/client": "{{holochain_client_version}}",
Expand Down
2 changes: 1 addition & 1 deletion templates/vanilla/web-app/ui/package.json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"scripts": {
"start": "vite --clearScreen false --port $UI_PORT",
"build": "vite build",
"package": "npm run build && cd dist && bestzip ../dist.zip *"
"package": "npm run build && rimraf dist.zip && cd dist && bestzip ../dist.zip *"
},
"dependencies": {
"@holochain/client": "{{holochain_client_version}}",
Expand Down
5 changes: 3 additions & 2 deletions templates/vue/web-app/ui/package.json.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
"build": "npm run check && vite build",
{{#if holo_enabled}}
"build:holo": "VITE_APP_IS_HOLO=true vite build",
"package:holo": "npm run build:holo && cd dist && bestzip ../dist.zip *",
"package:holo": "npm run build:holo && rimraf dist.zip && cd dist && bestzip ../dist.zip *",
{{/if}}
"check": "vue-tsc --noEmit",
"preview": "vite preview",
"package": "npm run build && cd dist && bestzip ../dist.zip *"
"package": "npm run build && rimraf dist.zip && cd dist && bestzip ../dist.zip *"
},
"dependencies": {
"@holochain/client": "{{holochain_client_version}}",
Expand All @@ -34,6 +34,7 @@
"devDependencies": {
"@vitejs/plugin-vue": "^4.0.0",
"bestzip": "^2.2.0",
"rimraf": "^3.0.2",
"typescript": "^4.9.3",
"vite": "^4.0.4",
"vite-plugin-checker": "^0.5.1",
Expand Down