Add fix to prevent accumulation of dist.zip content #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c12i
approved these changes
Jun 4, 2024
c12i
pushed a commit
to c12i/scaffolding
that referenced
this pull request
Jun 4, 2024
c12i
added
ShouldBackport/0.2
c12i
pushed a commit
to c12i/scaffolding
that referenced
this pull request
Jun 5, 2024
c12i
added a commit
that referenced
this pull request
Jun 6, 2024
* fix: poorly formatted rust code (#288) * fix: poorly formatted code in coordinator zome * document add_newlines * clearn up coordinators module * clean up integrity module * refactor utils * fix add_newlines * update integrity comments * fix map file calls * fix add_newlines * make add_newlines public/private function agnostic * refactor link-type coordinator * fix remove link handler * fix collection coordinator * clean up entry-type coordinator * fix clippy warnings * refactor link-type coordinator * fix bug scaffolding entry-type with linked_from * fix target_hash_variable * remove unnecessary format usage * remove unnecessary clone * fix validate_delete_result * move comment * fix entry from rcord error message * rename unparse function to unparse_pretty; * feat: add long disable fast track option to hc scaffold web-app (#293) * add fix to prevent accumulation of dist.zip content (#300) * chore: bump version --------- Co-authored-by: matthme <36768177+matthme@users.noreply.github.com>
c12i
removed
the
ShouldBackport/0.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have added this a long time ago. It turns out that the
dist.zipfile keeps accumulating in size with eachnpm run packagestep if it is not being removed before packaging (presumably because bestzip does not overwrite the dist.zip file and if files in the dist folder get renamed they are simply added to the archive). That way webhapps can grow to humongous sizes over time without the developer being aware of it.