-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add relationshipType and id #21
Conversation
relationshipType: relationshipTypes/set | ||
source: parent-group | ||
target: subgroup | ||
label: "are part of {target}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this label be something like "is parent group of {target}"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right.
This has evolved since then in my local. Since I'm developing this in tandem with the query
branch I'll close this and do a pr when both are ready.
question: how do we feel about the |
👍 Good idea. |
|
|
|
hmm, thanks for the data, but i question the usefulness of these ngram searches. if a phrase is used the most within existing literature, that doesn't really tell us anything about whether it's a good idea to use in Holodex. in fact i wonder if in some cases the opposite is true, a generic phrase may be common but might also be confusing (e.g. "belongs to", "includes" "contains"). a poll of users would be ideal, but i feel good with us going with our gut on these naming questions, as no matter what it's impossible for us to truly know what is best, there are no objective answers to these questions. |
@ahdinosaur this branch works with the |
name: member | ||
pluralName: members | ||
relationshipType: relationshipTypes/membership | ||
label: "People in {target}" | ||
linkType: linkTypes/belongs-to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line shouldn't exist
ok @ahdinosaur less bikeshedding more compliance |
add relationshipType and id
No description provided.