Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add relationshipType and id #21

Merged
merged 6 commits into from
Jul 28, 2015
Merged

add relationshipType and id #21

merged 6 commits into from
Jul 28, 2015

Conversation

simontegg
Copy link
Contributor

No description provided.

relationshipType: relationshipTypes/set
source: parent-group
target: subgroup
label: "are part of {target}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this label be something like "is parent group of {target}"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right.

This has evolved since then in my local. Since I'm developing this in tandem with the query branch I'll close this and do a pr when both are ready.

@ahdinosaur
Copy link
Contributor

question: how do we feel about the ids being more like the labels? as in, instead of steward>stewardee it be stewards? i'm hoping to use these link type ids within the spreadsheet interface, so friendly ids are important for link types, having to know both roles seems unfriendly.

@simontegg
Copy link
Contributor Author

👍 Good idea.

@simontegg
Copy link
Contributor Author

People that are members of
People that belong to
People that are part of

N-gram search

@simontegg
Copy link
Contributor Author

Groups that are part of
Groups that are subgroups of
Groups that belong to

Ngram search

@simontegg
Copy link
Contributor Author

groups that include
groups that contain
has subgroup

Ngram search

@ahdinosaur
Copy link
Contributor

hmm, thanks for the data, but i question the usefulness of these ngram searches. if a phrase is used the most within existing literature, that doesn't really tell us anything about whether it's a good idea to use in Holodex. in fact i wonder if in some cases the opposite is true, a generic phrase may be common but might also be confusing (e.g. "belongs to", "includes" "contains"). a poll of users would be ideal, but i feel good with us going with our gut on these naming questions, as no matter what it's impossible for us to truly know what is best, there are no objective answers to these questions.

@simontegg
Copy link
Contributor Author

@ahdinosaur this branch works with the query on app and should be good

name: member
pluralName: members
relationshipType: relationshipTypes/membership
label: "People in {target}"
linkType: linkTypes/belongs-to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line shouldn't exist

@simontegg
Copy link
Contributor Author

ok @ahdinosaur less bikeshedding more compliance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants