-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #115
Support Python 3.12 #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Normally I'd suggest removing 3.7 and maybe 3.8 when adding new versions, but if it passes I guess we can just keep it since colorcet doesn't get very many commits and the extra CI time is thus probably negligible. I'll merge if the tests pass.
Hmm. Python 3.12 is available on the main conda channel, but it looks like something else isn't yet? Not sure... |
I have never used (ana)conda, so its' hard for me to say. This does not even look like a conflict to me:
Maybe conda/conda#13072 (comment)? |
Would it make sense to simply retry this one? Edit: My rationale is that after reading https://stackoverflow.com/a/69137255/880783, I am convinced that the reported conflict is not a conflict at all; and after reading https://stackoverflow.com/a/69922162/880783 (and conda/conda#13072 (comment)) I find it likely that some package binary just wasn't made available for Python yet, and I give it good chances that that has changed in the meantime. Edit2: In fact, py312 files for pyct (https://anaconda.org/anaconda/pyct/files) have only been added in November, after our last run. So, yes, @jbednar, if you could please kick off CI again, please? :) |
Alas, not successful yet! |
Probably to work around that, and other packages not available yet for Python 3.12, Simon added a special job for running the tests on Python 3.12 using @jbednar would you be fine if |
Sure, that would be fine. There shouldn't be any special dependency relationships that would require conda! |
Now that 3.12 passes, 3.7 fails 🤪 |
Obsoleted by #120. |
Closes #114