Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.12 #115

Closed
wants to merge 6 commits into from
Closed

Support Python 3.12 #115

wants to merge 6 commits into from

Conversation

bersbersbers
Copy link

Closes #114

@bersbersbers bersbersbers mentioned this pull request Oct 26, 2023
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Normally I'd suggest removing 3.7 and maybe 3.8 when adding new versions, but if it passes I guess we can just keep it since colorcet doesn't get very many commits and the extra CI time is thus probably negligible. I'll merge if the tests pass.

@jbednar
Copy link
Member

jbednar commented Oct 26, 2023

Hmm. Python 3.12 is available on the main conda channel, but it looks like something else isn't yet? Not sure...

@bersbersbers
Copy link
Author

I have never used (ana)conda, so its' hard for me to say.

This does not even look like a conflict to me:

Package python conflicts for:
pyctdev -> cloudpickle -> python[version='>=2.7,<2.8.0a0|>=3|>=3.10,<3.11.0a0|>=3.11,<3.12.0a0|>=3.9,<3.10.0a0|>=3.8,<3.9.0a0|>=3.6|>=3.5|>=3.7,<3.8.0a0|>=3.6,<3.7.0a0|>=3.5,<3.6.0a0|>=3.12,<3.13.0a0']
pyctdev -> python[version='>=2.7']
python=3.12

Maybe conda/conda#13072 (comment)?

@bersbersbers
Copy link
Author

bersbersbers commented Nov 28, 2023

Would it make sense to simply retry this one?

Edit: My rationale is that after reading https://stackoverflow.com/a/69137255/880783, I am convinced that the reported conflict is not a conflict at all; and after reading https://stackoverflow.com/a/69922162/880783 (and conda/conda#13072 (comment)) I find it likely that some package binary just wasn't made available for Python yet, and I give it good chances that that has changed in the meantime.

Edit2: In fact, py312 files for pyct (https://anaconda.org/anaconda/pyct/files) have only been added in November, after our last run.

So, yes, @jbednar, if you could please kick off CI again, please? :)

@jbednar
Copy link
Member

jbednar commented Nov 28, 2023

Alas, not successful yet!

@maximlt
Copy link
Member

maximlt commented Nov 29, 2023

pyctdev has conda-build as a dependency (when installed from conda) and conda-build has not yet been built for Python 3.12 (on defaults, but also on conda-forge which is unusual).

Probably to work around that, and other packages not available yet for Python 3.12, Simon added a special job for running the tests on Python 3.12 using pip only to some of the HoloViz packages, like hvPlot.

@jbednar would you be fine if colorcet's infrastructure was no longer depending on conda at all? It has a pretty simple set of dependencies to install. It's already the case for Param, and I just saw that it's also the case for HoloNote.

@jbednar
Copy link
Member

jbednar commented Nov 29, 2023

Sure, that would be fine. There shouldn't be any special dependency relationships that would require conda!

@bersbersbers
Copy link
Author

Now that 3.12 passes, 3.7 fails 🤪

@bersbersbers
Copy link
Author

Obsoleted by #120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
3 participants