Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single category reductions #1231

Merged
merged 1 commit into from Jun 12, 2023
Merged

Fix single category reductions #1231

merged 1 commit into from Jun 12, 2023

Conversation

ianthomas23
Copy link
Member

@ianthomas23 ianthomas23 commented Jun 9, 2023

Fixes #1230.

Single character fix! The important thing is the new test so that failures like this cannot happen again without us noticing.

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #1231 (af8e9fc) into main (f917cd9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1231   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files          35       35           
  Lines        8751     8751           
=======================================
  Hits         7315     7315           
  Misses       1436     1436           
Impacted Files Coverage Δ
datashader/reductions.py 79.02% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 9ad8aeb into holoviz:main Jun 12, 2023
16 checks passed
@ianthomas23 ianthomas23 deleted the 1142_one_category branch June 12, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduction ds.by() with one category now fails on 0.15.0
1 participant