Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorical max_row_index, max_n_row_index and min equivalents #1233

Merged
merged 2 commits into from Jun 13, 2023
Merged

Categorical max_row_index, max_n_row_index and min equivalents #1233

merged 2 commits into from Jun 13, 2023

Conversation

ianthomas23
Copy link
Member

This is part two of issue #1210. It adds support for reductions like these:

  • by("cat", _max_row_index())
  • by("cat", _min_row_index())
  • by("cat", _max_n_row_index(n=3))
  • by("cat", _min_n_row_index(n=3))

on CPU and GPU, with and without dask.

The remainder of #1210 will be a single larger PR to provide support for by-where reductions such as

  • by("cat", where(max("value"), "other"))

@ianthomas23 ianthomas23 added this to the v0.15.1 milestone Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1233 (4cf7770) into main (f917cd9) will decrease coverage by 0.03%.
The diff coverage is 64.55%.

@@            Coverage Diff             @@
##             main    #1233      +/-   ##
==========================================
- Coverage   83.59%   83.56%   -0.03%     
==========================================
  Files          35       35              
  Lines        8751     8773      +22     
==========================================
+ Hits         7315     7331      +16     
- Misses       1436     1442       +6     
Impacted Files Coverage Δ
datashader/transfer_functions/_cuda_utils.py 20.63% <0.00%> (ø)
datashader/reductions.py 78.86% <57.14%> (-0.17%) ⬇️
datashader/compiler.py 88.54% <100.00%> (+0.12%) ⬆️
datashader/utils.py 81.72% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 3317542 into holoviz:main Jun 13, 2023
14 of 16 checks passed
@ianthomas23 ianthomas23 deleted the cat_max_row_index branch June 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant