Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganise antialiasing code #1245

Merged
merged 3 commits into from Jul 4, 2023
Merged

Reorganise antialiasing code #1245

merged 3 commits into from Jul 4, 2023

Conversation

ianthomas23
Copy link
Member

This is a reorganisation of some of the antialiasing code to make it easier to understand. It uses a NamedTuple for AntialiasingStage2 rather than just a tuple, and moves the antialiasing code from various locations to a new antialias.py source code file.

This is a precursor to the AntialiasingStage2 becoming more complicated.

@ianthomas23 ianthomas23 added this to the v0.15.1 milestone Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #1245 (65b1f39) into main (d534e2d) will decrease coverage by 0.01%.
The diff coverage is 92.62%.

@@            Coverage Diff             @@
##             main    #1245      +/-   ##
==========================================
- Coverage   83.42%   83.42%   -0.01%     
==========================================
  Files          35       35              
  Lines        8858     8869      +11     
==========================================
+ Hits         7390     7399       +9     
- Misses       1468     1470       +2     
Impacted Files Coverage Δ
datashader/glyphs/__init__.py 100.00% <ø> (ø)
datashader/compiler.py 88.32% <75.00%> (-0.34%) ⬇️
datashader/reductions.py 77.87% <81.25%> (ø)
datashader/antialias.py 96.55% <96.55%> (ø)
datashader/glyphs/line.py 92.86% <100.00%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit faff0eb into holoviz:main Jul 4, 2023
15 of 16 checks passed
@ianthomas23 ianthomas23 deleted the antialias_reorg branch July 4, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant