Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support summary containing multiple where reductions with the same selector #1271

Merged
merged 1 commit into from Aug 16, 2023
Merged

Support summary containing multiple where reductions with the same selector #1271

merged 1 commit into from Aug 16, 2023

Conversation

ianthomas23
Copy link
Member

@ianthomas23 ianthomas23 commented Aug 16, 2023

Fixes #1270.

Previously, a summary reduction containing multiple where reductions that use the same selector gave an error. With this PR they work as expected.

Example of what previously failed but now works:

canvas.line(...,
    agg=ds.summary(
        name1=ds.where(ds.max("value"), "other"),
        name2=ds.where(ds.max("value")),
    )
)

@ianthomas23 ianthomas23 added this to the v0.15.2 milestone Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #1271 (ac5e125) into main (ea163e9) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
+ Coverage   83.51%   83.53%   +0.01%     
==========================================
  Files          35       35              
  Lines        9117     9128      +11     
==========================================
+ Hits         7614     7625      +11     
  Misses       1503     1503              
Files Changed Coverage Δ
datashader/compiler.py 89.79% <100.00%> (+0.39%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit 765e82e into holoviz:main Aug 16, 2023
16 checks passed
@ianthomas23 ianthomas23 deleted the 1270_summary_where branch August 16, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in summary reduction using multiple where reductions with the same selector
1 participant