Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geopandas example #1297

Merged
merged 4 commits into from Oct 26, 2023
Merged

Geopandas example #1297

merged 4 commits into from Oct 26, 2023

Conversation

ianthomas23
Copy link
Member

This adds a new page to the User Guide in the docs to show use of GeoPandas. It uses one of the geodatasets and shows three images, one of which is (population density per US county in 1990):

Screenshot 2023-10-25 at 15 16 44

It is minimalistic at this stage as it uses pure Datashader. When we have support in HoloViews for this, we can add an interactive section to the end and hence show interactive zooming and panning, and show colorbars as well, to make it more interesting.

@ianthomas23 ianthomas23 added the docs Related to documentation label Oct 25, 2023
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you include a sentence or two in the new notebook about the tradeoffs between GeoPandas and SpatialPandas? Presumably something about one being faster, but the other being more convenient if you are already have your data in GeoPandas?

@ianthomas23
Copy link
Member Author

Looks good! Can you include a sentence or two in the new notebook about the tradeoffs between GeoPandas and SpatialPandas? Presumably something about one being faster, but the other being more convenient if you are already have your data in GeoPandas?

Yes, I'll do that.

@ianthomas23
Copy link
Member Author

The new page is at https://holoviz-dev.github.io/datashader/user_guide/Geopandas.html in the dev docs.

@jbednar
Copy link
Member

jbednar commented Oct 25, 2023

Looks good, thanks! I forget -- do we have antialiasing supported for polygons? If so it would be good to add that to the example.

@ianthomas23
Copy link
Member Author

Looks good, thanks! I forget -- do we have antialiasing supported for polygons?

No, there is only antialiasing support for lines.

@jbednar
Copy link
Member

jbednar commented Oct 25, 2023

Oops; I wasn't clear. I meant, antialiasing for polygon outlines. Those are just polylines, so I'd think they should be supported?

@ianthomas23
Copy link
Member Author

Oops; I wasn't clear. I meant, antialiasing for polygon outlines. Those are just polylines, so I'd think they should be supported?

Yes, any use of Canvas.line() supports antialiasing regardless of the type of the source. Here it is with line_width=2:

Screenshot 2023-10-26 at 08 56 09

@ianthomas23 ianthomas23 merged commit e742957 into main Oct 26, 2023
1 of 4 checks passed
@ianthomas23 ianthomas23 deleted the geopandas_example branch October 26, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants