Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of matplotlib legend code #211

Closed
philippjfr opened this issue Jul 9, 2015 · 1 comment
Closed

Refactoring of matplotlib legend code #211

philippjfr opened this issue Jul 9, 2015 · 1 comment

Comments

@philippjfr
Copy link
Member

Currently the way legends are handled is a bit awkward as there are two possible places the legends can be drawn from:

  1. The label of each Element
  2. The multi-dimensional index in NdOverlay

These are currently handled semi-separately, the Element labels are set on the artists directly, while the OverlayPlot looks through the handles of all the subplots to associate the NdOverlay index with a particularly artist.

Instead each ElementPlot should simply be passed this index and set the legend options directly in the plotting call. This probably fits into a more general system, which would make the NdLayout, GridSpace, NdOverlay dimensions and corresponding values available to each ElementPlot.

@philippjfr
Copy link
Member Author

This was actually done a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant