Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hv.Empty not working in AdjointLayout plot #5584

Merged
merged 4 commits into from Jan 11, 2023
Merged

Fix hv.Empty not working in AdjointLayout plot #5584

merged 4 commits into from Jan 11, 2023

Conversation

Hoxbro
Copy link
Member

@Hoxbro Hoxbro commented Jan 6, 2023

Fixes #5559

Small regression, which made the following code error.

import holoviews as hv
import numpy as np

hv.extension("bokeh")

scatter = hv.Scatter(np.random.rand(100, 2))
scatter << hv.Empty() << scatter.hist(adjoin=False)

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2023

Codecov Report

Merging #5584 (8d426a4) into main (c306af3) will decrease coverage by 3.96%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##             main    #5584      +/-   ##
==========================================
- Coverage   88.22%   84.26%   -3.97%     
==========================================
  Files         302      302              
  Lines       62185    62183       -2     
==========================================
- Hits        54864    52398    -2466     
- Misses       7321     9785    +2464     
Impacted Files Coverage Δ
holoviews/ipython/display_hooks.py 59.70% <0.00%> (-0.61%) ⬇️
holoviews/core/layout.py 75.60% <100.00%> (ø)
holoviews/plotting/plot.py 93.25% <100.00%> (ø)
holoviews/tests/plotting/bokeh/test_layoutplot.py 100.00% <100.00%> (ø)
holoviews/tests/operation/test_datashader.py 1.75% <0.00%> (-95.87%) ⬇️
holoviews/operation/datashader.py 0.70% <0.00%> (-83.29%) ⬇️
holoviews/core/data/spatialpandas.py 14.70% <0.00%> (-72.61%) ⬇️
holoviews/tests/core/data/test_spatialpandas.py 34.13% <0.00%> (-64.08%) ⬇️
holoviews/core/data/spatialpandas_dask.py 50.79% <0.00%> (-31.75%) ⬇️
holoviews/tests/core/test_decollation.py 78.12% <0.00%> (-21.88%) ⬇️
... and 33 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

holoviews/core/layout.py Outdated Show resolved Hide resolved
@jlstevens
Copy link
Contributor

jlstevens commented Jan 9, 2023

Looks good to me!

Happy to see this merged once there are some unit tests. Docs updates can be in a separate PR.

@Hoxbro Hoxbro changed the title Fix empty plot Fix hv.Empty in an adjoint plot Jan 10, 2023
@Hoxbro Hoxbro changed the title Fix hv.Empty in an adjoint plot Fix hv.Empty in an AdjointLayout plot Jan 11, 2023
@Hoxbro Hoxbro changed the title Fix hv.Empty in an AdjointLayout plot Fix hv.Empty not working in AdjointLayout plot Jan 11, 2023
@Hoxbro Hoxbro merged commit 22d6205 into main Jan 11, 2023
@Hoxbro Hoxbro deleted the fix_empty_plot branch January 11, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trying to add marginal histogram to just one axis
4 participants