Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bokeh FuncTickFormatter signature change in 0.12.3 #885

Closed
philippjfr opened this issue Sep 26, 2016 · 5 comments
Closed

Bokeh FuncTickFormatter signature change in 0.12.3 #885

philippjfr opened this issue Sep 26, 2016 · 5 comments

Comments

@philippjfr
Copy link
Member

In the upcoming release of bokeh the signature of the FuncTickFormatters will change requiring a change in the way they are used in holoviews.

@jlstevens jlstevens added this to the v1.7.0 milestone Sep 26, 2016
@jlstevens
Copy link
Contributor

I've assigned the v1.7.0 milestone on the assumption that this is the next HoloViews release and that these changes to bokeh will still be relevant at that time.

@stonebig
Copy link
Contributor

users wanting Bokeh-0.12.3 to get matplotlib2 fixes, may also wish the Holoview fix.

v1.7.0 seems too far away

@jlstevens
Copy link
Contributor

v1.7.0 seems too far away

We've been discussing the possibility of some sort of release before then but nothing concrete has been decided yet.

@philippjfr
Copy link
Member Author

So I've just investigated this and it seems bokeh has made the function signature inconsistent with what we can support. A valid bokeh FuncTickFormatter now looks like this:

def ticker():
    return "{:.0f} + {:.2f}".format(tick, tick % 1)

i.e. it no longer supports a first argument and instead defines tick as a special value, which is made available in the namespace of the function. I'm now not sure how we can get around this, except allowing this signature in general somehow.

@philippjfr
Copy link
Member Author

This has now been fixed. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants