Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.FunctionType to Callable #5636

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 3, 2023

Fixes #5635

When running the test locally with the nightly Numpy build, I get the following errors, which need to be investigated. I will do it when a more stable dev release is released.

FAILED holoviews/tests/core/test_apply.py::test_nested_widgets - AttributeError: 'df_dim' object has no attribute 'ops'
FAILED holoviews/tests/core/test_apply.py::test_slice_iloc - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/core/test_apply.py::test_slice_loc - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/plotting/bokeh/test_elementplot.py::TestOverlayPlot::test_clim_percentile - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_cumsum_transform - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_max_transform - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_min_transform - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_pandas_chained_methods - AttributeError: 'df_dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_std_transform - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_sum_transform - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_var_transform - AttributeError: 'dim' object has no attribute 'ops'
FAILED holoviews/tests/util/test_transform.py::TestDimTransforms::test_xarray_coarsen_method - AttributeError: 'xr_dim' object has no attribute 'ops'

The error is coming from here:

ops = super().__getattribute__('ops')

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #5636 (df71c8c) into main (4e83af3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5636   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files         302      302           
  Lines       62517    62517           
=======================================
  Hits        55180    55180           
  Misses       7337     7337           
Impacted Files Coverage Δ
holoviews/plotting/bokeh/hex_tiles.py 94.73% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 245d5cf into main Mar 3, 2023
@hoxbro hoxbro deleted the initial_numpy_1_25_support branch March 3, 2023 13:21
@djhoese
Copy link

djhoese commented Mar 3, 2023

I can confirm this fixes the issue I was running into. Thanks so much for a quick fix. Any idea on a release timeline that will include this?

@hoxbro
Copy link
Member Author

hoxbro commented Mar 6, 2023

No imminent release is planned, but A dev release could be done this week.

@djhoese
Copy link

djhoese commented Mar 6, 2023

Ok, our tests that were failing weren't installing dev versions of holoviz packages so this isn't urgent for us. We'll just have to wait for the full release. If numpy's change is released with numpy 1.25.0 then it probably won't be a problem until July (https://github.com/numpy/numpy/milestone/113).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import of holoviews.plotting.bokeh fails with nightly/dev numpy
3 participants