Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit warnings when toolbar is disabled #5691

Merged
merged 1 commit into from Apr 24, 2023
Merged

Don't emit warnings when toolbar is disabled #5691

merged 1 commit into from Apr 24, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 24, 2023

Fixes #5688

If self.toobar is disabled do not try to set up active tools.

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2023

Codecov Report

Merging #5691 (e5704fe) into main (38a4350) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5691      +/-   ##
==========================================
- Coverage   88.30%   88.29%   -0.01%     
==========================================
  Files         302      302              
  Lines       62586    62586              
==========================================
- Hits        55264    55263       -1     
- Misses       7322     7323       +1     
Impacted Files Coverage Δ
holoviews/plotting/bokeh/element.py 88.11% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro changed the title Don't emit a warning when toolbar is disabled Don't emit warnings when toolbar is disabled Apr 24, 2023
@hoxbro hoxbro merged commit c1803f8 into main Apr 24, 2023
16 checks passed
@hoxbro hoxbro deleted the disable_toolbar branch April 24, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing warning for disabled toolbar
2 participants