Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collector catches Task failures and warns #570

Merged
merged 1 commit into from
Mar 23, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions holoviews/interface/collector.py
Original file line number Diff line number Diff line change
Expand Up @@ -545,11 +545,16 @@ def __call__(self, attrtree=Layout(), times=[], strict=False):
# computing results over the entire accumulated map
attrtree_buffer = Layout()
for task in self._scheduled_tasks:
if isinstance(task, Analyze) and task.mapwise:
task(attrtree, self.time_fn(), times)
else:
task(attrtree_buffer, self.time_fn(), times)
attrtree.update(attrtree_buffer)
try:
if isinstance(task, Analyze) and task.mapwise:
task(attrtree, self.time_fn(), times)
else:
task(attrtree_buffer, self.time_fn(), times)
attrtree.update(attrtree_buffer)
except Exception as e:
param.main.warning("Task %s at time %s failed with following "
"exception and was skipped:\n%s",
task, self.time_fn(), e)
if update_progress:
interval_hook.percent_range = (completion[i],
completion[i+1])
Expand Down