Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for numpy arrays with object dtype #5733

Merged
merged 2 commits into from Jun 2, 2023

Conversation

Hoxbro
Copy link
Member

@Hoxbro Hoxbro commented Jun 2, 2023

This adds a workaround for #5722 and #5726 until it is fixed upstream.

@Hoxbro Hoxbro added this to the 1.16.1 milestone Jun 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #5733 (d8cadc0) into main (f4c4c12) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5733      +/-   ##
==========================================
- Coverage   88.24%   88.22%   -0.02%     
==========================================
  Files         304      305       +1     
  Lines       62680    62716      +36     
==========================================
+ Hits        55309    55333      +24     
- Misses       7371     7383      +12     
Impacted Files Coverage Δ
holoviews/element/comparison.py 90.44% <100.00%> (+0.06%) ⬆️
holoviews/plotting/bokeh/element.py 88.19% <100.00%> (+0.02%) ⬆️
holoviews/plotting/bokeh/util.py 66.92% <100.00%> (+0.63%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Hoxbro Hoxbro mentioned this pull request Jun 2, 2023
3 tasks
@Hoxbro Hoxbro merged commit d6298a4 into main Jun 2, 2023
16 checks passed
@Hoxbro Hoxbro deleted the workaround_dtype_object branch June 2, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants