New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugbear lint #5768
Bugbear lint #5768
Conversation
db79b18
to
3a43cee
Compare
Codecov Report
@@ Coverage Diff @@
## main #5768 +/- ##
==========================================
- Coverage 88.18% 88.18% -0.01%
==========================================
Files 306 306
Lines 62739 62812 +73
==========================================
+ Hits 55326 55390 +64
- Misses 7413 7422 +9
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know bugbear, for reference this is originally a flake8 plugin that was re-implemented by ruff. Some of the changes made by the tools look dubious to me, I think it's worth reviewing it in details before merging.
Updates to codebase with Bugbear running:
ruff holoviews --select=B --ignore=B006,B904,B015,B018
.For now, I have not enabled it by default.
Running the command will still give the following errors: