Add an extra try when resolving attributes lookup #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5780 +/- ##
==========================================
- Coverage 88.16% 88.14% -0.03%
==========================================
Files 307 307
Lines 62839 62851 +12
==========================================
- Hits 55405 55401 -4
- Misses 7434 7450 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hoxbro
commented
Jun 23, 2023
Hoxbro
changed the title
resolve_attr_spec
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5746
Giving 5 times to try to resolve the attribute with a delay of 0.01 seconds.
asyncio.sleep(0.01)is already used once before in the method, and 5 is an arbitrary choice that worked on my computer.I also made minor changes by using
isequalfor comparison and setting anExceptiontoAttributeError, which are not related to the original issues.