Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram operation on Ibis data #5929

Merged
merged 9 commits into from Oct 9, 2023
Merged

Fix histogram operation on Ibis data #5929

merged 9 commits into from Oct 9, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 8, 2023

While working on holoviz/hvplot#997 I realized that (perhaps unsurprisingly) some Ibis code paths were broken or not working as expected. I fixed some bugs related to API changes in ibis after version 5.0 and a bug in the histogram computation when density=True.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2023

Codecov Report

Merging #5929 (ef407f4) into main (adbfe2c) will increase coverage by 0.03%.
The diff coverage is 90.38%.

@@            Coverage Diff             @@
##             main    #5929      +/-   ##
==========================================
+ Coverage   88.42%   88.45%   +0.03%     
==========================================
  Files         313      313              
  Lines       65160    65209      +49     
==========================================
+ Hits        57619    57683      +64     
+ Misses       7541     7526      -15     
Flag Coverage Δ
ui-tests 23.27% <32.69%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/core/data/ibis.py 82.01% <100.00%> (+4.85%) ⬆️
holoviews/operation/element.py 75.59% <75.00%> (+1.04%) ⬆️
holoviews/tests/conftest.py 86.66% <80.00%> (-3.34%) ⬇️
holoviews/tests/operation/test_operation.py 98.57% <93.75%> (-0.63%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maximlt
Copy link
Member Author

maximlt commented Oct 8, 2023

When this eventually gets merged after review/changes, is it possible to get a quick dev release? I'd need one to merge holoviz/hvplot#997 (unless I pin ibis there).

holoviews/tests/operation/test_operation.py Outdated Show resolved Hide resolved
holoviews/core/data/ibis.py Show resolved Hide resolved
holoviews/core/data/ibis.py Show resolved Hide resolved
@Hoxbro Hoxbro enabled auto-merge (squash) October 9, 2023 14:09
@Hoxbro Hoxbro added type: bug Something isn't correct or isn't working tag: hvplot Issue originally related to hvplot labels Oct 9, 2023
@Hoxbro
Copy link
Member

Hoxbro commented Oct 9, 2023

LGTM 👍

@Hoxbro Hoxbro merged commit 8ba691a into main Oct 9, 2023
11 checks passed
@Hoxbro Hoxbro deleted the ibis_histogram_fixes branch October 9, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: hvplot Issue originally related to hvplot type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants