Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Del frame after stack level is found #6085

Merged
merged 2 commits into from Jan 30, 2024
Merged

Del frame after stack level is found #6085

merged 2 commits into from Jan 30, 2024

Conversation

Hoxbro
Copy link
Member

@Hoxbro Hoxbro commented Jan 29, 2024

It can lead to memory leaks if not deleted.

@Hoxbro Hoxbro added the type: bug Something isn't correct or isn't working label Jan 29, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (30044d4) 88.68% compared to head (819a534) 88.66%.

Files Patch % Lines
holoviews/util/warnings.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6085      +/-   ##
==========================================
- Coverage   88.68%   88.66%   -0.02%     
==========================================
  Files         314      314              
  Lines       65872    65874       +2     
==========================================
- Hits        58420    58410      -10     
- Misses       7452     7464      +12     
Flag Coverage Δ
ui-tests 23.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hoxbro Hoxbro merged commit 90b8816 into main Jan 30, 2024
12 of 13 checks passed
@Hoxbro Hoxbro deleted the update_stacklevel branch January 30, 2024 21:19
Hoxbro added a commit that referenced this pull request Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants