Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add group and label to hover tooltip if provided by user #6125

Closed
wants to merge 9 commits into from
Closed

Add group and label to hover tooltip if provided by user #6125

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c24cc80
add group and label to bokeh hover tooltip if provided by user
droumis Feb 20, 2024
b735d80
rename func to be more descriptive
droumis Feb 21, 2024
272c296
safer check of element group default
droumis Feb 21, 2024
3b5f744
skip if group or label are data dims
droumis Feb 21, 2024
83c22e4
force lowercase on existing tooltips for checking
droumis Feb 21, 2024
e0f2fdd
add unit tests
droumis Feb 21, 2024
d3f8bd2
move group label tt tests to test_elementplot
droumis Feb 22, 2024
06755bb
mutate tooltips in place and end early if match in data dim
droumis Feb 22, 2024
000f159
add test for whitespace and special chars
droumis Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions holoviews/plotting/bokeh/element.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,16 @@ def _hover_opts(self, element):
dims += element.dimensions()
return list(util.unique_iterator(dims)), {}

def _group_label(self, element):
droumis marked this conversation as resolved.
Show resolved Hide resolved
# return group and label if present
group_label = []
# group is the element type by default (e.g. Curve)
if hasattr(element, 'group') and element.group != type(element).__name__:
droumis marked this conversation as resolved.
Show resolved Hide resolved
group_label.append(('Group', element.group))
if hasattr(element, 'label') and element.label:
group_label.append(('Label', element.label))
return group_label

def _init_tools(self, element, callbacks=None):
"""
Processes the list of tools to be supplied to the plot.
Expand All @@ -295,6 +305,7 @@ def _init_tools(self, element, callbacks=None):
tooltips, hover_opts = self._hover_opts(element)
tooltips = [(ttp.pprint_label, '@{%s}' % util.dimension_sanitizer(ttp.name))
if isinstance(ttp, Dimension) else ttp for ttp in tooltips]
tooltips += self._group_label(element)
droumis marked this conversation as resolved.
Show resolved Hide resolved
if not tooltips: tooltips = None

callbacks = callbacks+self.callbacks
Expand Down