Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky pop up ui tests #6199

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Fix flaky pop up ui tests #6199

merged 4 commits into from
Apr 19, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 19, 2024

The flaky test is likely because the tap sometimes does not hit a value because the data is randomized.

This will always use the same seed and expand the hit dilation for one of the tests.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.10%. Comparing base (4727470) to head (028833a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6199   +/-   ##
=======================================
  Coverage   88.10%   88.10%           
=======================================
  Files         319      319           
  Lines       67156    67158    +2     
=======================================
+ Hits        59166    59168    +2     
  Misses       7990     7990           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Apr 19, 2024
@hoxbro hoxbro changed the title Fix flaky pop up ui test Fix flaky pop up ui tests Apr 19, 2024
@hoxbro hoxbro enabled auto-merge (squash) April 19, 2024 16:26
@hoxbro hoxbro merged commit 8507aab into main Apr 19, 2024
13 of 14 checks passed
@hoxbro hoxbro deleted the improve_popup_test branch April 19, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant